From a7e8a6eb83bedeb6c7d79b598a3f3024e321651c Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Sun, 22 Mar 2026 17:48:37 -0700
Subject: [PATCH] fix: unify time epoch across GetTime, cooldowns, auras, and
 cast bars
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Four independent static local steady_clock start times were used as
time origins in GetTime(), GetSpellCooldown(), UnitBuff expiration,
and UnitCastingInfo — each initializing on first call at slightly
different times. This created systematic timestamp mismatches.

When addons compute (start + duration - GetTime()), the start value
from GetSpellCooldown and the GetTime() return used different epochs,
causing cooldown sweeps and buff timers to appear offset.

Replace all four independent statics with a single file-scope
kLuaTimeEpoch constant and luaGetTimeNow() helper, ensuring all
time-returning Lua functions share exactly the same origin.
---
 src/addons/lua_engine.cpp | 31 ++++++++++++++-----------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/src/addons/lua_engine.cpp b/src/addons/lua_engine.cpp
index adabba49..3c45ec2f 100644
--- a/src/addons/lua_engine.cpp
+++ b/src/addons/lua_engine.cpp
@@ -18,6 +18,14 @@ extern "C" {
 
 namespace wowee::addons {
 
+// Shared GetTime() epoch — all time-returning functions must use this same origin
+// so that addon calculations like (start + duration - GetTime()) are consistent.
+static const auto kLuaTimeEpoch = std::chrono::steady_clock::now();
+
+static double luaGetTimeNow() {
+    return std::chrono::duration<double>(std::chrono::steady_clock::now() - kLuaTimeEpoch).count();
+}
+
 // Retrieve GameHandler pointer stored in Lua registry
 static game::GameHandler* getGameHandler(lua_State* L) {
     lua_getfield(L, LUA_REGISTRYINDEX, "wowee_game_handler");
@@ -1184,11 +1192,7 @@ static int lua_UnitAura(lua_State* L, bool wantBuff) {
                     std::chrono::duration_cast<std::chrono::milliseconds>(
                         std::chrono::steady_clock::now().time_since_epoch()).count());
                 int32_t remMs = aura.getRemainingMs(auraNowMs);
-                // GetTime epoch = steady_clock relative to engine start
-                static auto sStart = std::chrono::steady_clock::now();
-                double nowSec = std::chrono::duration<double>(
-                    std::chrono::steady_clock::now() - sStart).count();
-                lua_pushnumber(L, nowSec + remMs / 1000.0);
+                lua_pushnumber(L, luaGetTimeNow() + remMs / 1000.0);
             } else {
                 lua_pushnumber(L, 0);  // permanent aura
             }
@@ -1244,10 +1248,8 @@ static int lua_UnitCastInfo(lua_State* L, bool wantChannel) {
     const char* uid = luaL_optstring(L, 1, "player");
     std::string uidStr(uid ? uid : "player");
 
-    // GetTime epoch for consistent time values
-    static auto sStart = std::chrono::steady_clock::now();
-    double nowSec = std::chrono::duration<double>(
-        std::chrono::steady_clock::now() - sStart).count();
+    // Use shared GetTime() epoch for consistent timestamps
+    double nowSec = luaGetTimeNow();
 
     // Resolve cast state for the unit
     bool isCasting = false;
@@ -1544,9 +1546,7 @@ static int lua_GetSpellCooldown(lua_State* L) {
     float gcdTotal = gh->getGCDTotal();
 
     // WoW returns (start, duration, enabled) where remaining = start + duration - GetTime()
-    static auto sStart = std::chrono::steady_clock::now();
-    double nowSec = std::chrono::duration<double>(
-        std::chrono::steady_clock::now() - sStart).count();
+    double nowSec = luaGetTimeNow();
 
     if (cd > 0.01f) {
         // Spell-specific cooldown (longer than GCD)
@@ -4537,12 +4537,9 @@ static int lua_wow_time(lua_State* L) {
     return 1;
 }
 
-// Stub for GetTime() — returns elapsed seconds
+// GetTime() — returns elapsed seconds since engine start (shared epoch)
 static int lua_wow_gettime(lua_State* L) {
-    static auto start = std::chrono::steady_clock::now();
-    auto now = std::chrono::steady_clock::now();
-    double elapsed = std::chrono::duration<double>(now - start).count();
-    lua_pushnumber(L, elapsed);
+    lua_pushnumber(L, luaGetTimeNow());
     return 1;
 }