phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: populate unitAurasCache_ from SMSG_PARTY_MEMBER_STATS aura block
Some checks are pending
Build / Build (arm64) (push) Waiting to run
Details
Build / Build (x86-64) (push) Waiting to run
Details
Build / Build (macOS arm64) (push) Waiting to run
Details
Build / Build (windows-arm64) (push) Waiting to run
Details
Build / Build (windows-x86-64) (push) Waiting to run
Details
Security / CodeQL (C/C++) (push) Waiting to run
Details
Security / Semgrep (push) Waiting to run
Details
Security / Sanitizer Build (ASan/UBSan) (push) Waiting to run
Details

Browse source 
SMSG_PARTY_MEMBER_STATS includes a 64-bit aura presence mask + per-slot
spellId/flags that was previously read and discarded. Now populate
unitAurasCache_[memberGuid] from this data so party frame debuff dots
show even when no dedicated SMSG_AURA_UPDATE has been received for that
unit. For Classic/TBC (no flags byte), infer debuff status from dispel
type — any spell with a non-zero dispel type is treated as a debuff.
This commit is contained in:
Kelsi 2026-03-12 12:07:46 -07:00
parent 562fc13a6a
commit a90f2acd26
1 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/game/game_handler.cpp
View file

@ -15093,19 +15093,33 @@ void GameHandler::handlePartyMemberStats(network::Packet& packet, bool isFull) {
if (updateFlags & 0x0200) { // AURAS
if (remaining() >= 8) {
uint64_t auraMask = packet.readUInt64();
// Collect aura updates for this member and store in unitAurasCache_
// so party frame debuff dots can use them.
std::vector<AuraSlot> newAuras;
for (int i = 0; i < 64; ++i) {
if (auraMask & (uint64_t(1) << i)) {
AuraSlot a;
a.level = static_cast<uint8_t>(i); // use slot index
if (isWotLK) {
// WotLK: uint32 spellId + uint8 auraFlags
if (remaining() < 5) break;
packet.readUInt32();
packet.readUInt8();
a.spellId = packet.readUInt32();
a.flags = packet.readUInt8();
} else {
// Classic/TBC: uint16 spellId only
// Classic/TBC: uint16 spellId only; negative auras not indicated here
if (remaining() < 2) break;
packet.readUInt16();
a.spellId = packet.readUInt16();
// Infer negative/positive from dispel type: non-zero dispel → debuff
uint8_t dt = getSpellDispelType(a.spellId);
if (dt > 0) a.flags = 0x80; // mark as debuff
}
if (a.spellId != 0) newAuras.push_back(a);
}
}
// Populate unitAurasCache_ for this member (merge: keep existing per-GUID data
// only if we already have a richer source; otherwise replace with stats data)
if (memberGuid != 0 && memberGuid != playerGuid && memberGuid != targetGuid) {
unitAurasCache_[memberGuid] = std::move(newAuras);
}
}
}