refactor(chat): extract ItemTooltipRenderer, slim render(), consolidate utils

- Extract renderItemTooltip() (510 LOC) from ChatMarkupRenderer into
  dedicated ItemTooltipRenderer class; chat_markup_renderer.cpp 766→192 LOC
- Extract formatChatMessage(), detectChannelPrefix(), inputTextCallback()
  from render(); render() 711→376 LOC
- Consolidate replaceGenderPlaceholders() from 3 copies into
  chat_utils::replaceGenderPlaceholders(); remove 118 LOC duplicate from
  quest_log_screen.cpp, update 8 call sites in window_manager.cpp
- Delete chat_panel_commands.cpp (359 LOC) — absorb sendChatMessage,
  executeMacroText, PortBot helpers into chat_panel.cpp; move
  evaluateMacroConditionals to macro_eval_convenience.cpp
- Delete chat_panel_utils.cpp (229 LOC) — absorb small utilities into
  chat_panel.cpp
- Replace 3 forward declarations of evaluateMacroConditionals with
  #include "ui/chat/macro_evaluator.hpp"

Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
This commit is contained in:
Pavel Okhlopkov 2026-04-12 15:46:03 +03:00
parent 42f1bb98ea
commit ada019e0d4
17 changed files with 1302 additions and 1463 deletions

View file

@ -1,14 +1,18 @@
#pragma once
#include "game/world_packets.hpp"
#include "game/entity.hpp"
#include <algorithm>
#include <cctype>
#include <memory>
#include <string>
namespace wowee {
// Forward declaration
namespace game { class GameHandler; }
// Forward declarations
namespace game {
class GameHandler;
}
namespace ui {
namespace chat_utils {
@ -38,6 +42,17 @@ inline std::string toLower(std::string s) {
return s;
}
/**
* Replace $g/$G gender, $n/$N name, $c/$C class, $r/$R race,
* $p/$o/$s/$S pronoun, $b/$B linebreak, and |n linebreak placeholders.
* Extracted from ChatPanel::replaceGenderPlaceholders (Phase 6.6).
*/
std::string replaceGenderPlaceholders(const std::string& text,
game::GameHandler& gameHandler);
/** Get display name for any entity (Player/Unit/GameObject). */
std::string getEntityDisplayName(const std::shared_ptr<game::Entity>& entity);
} // namespace chat_utils
} // namespace ui
} // namespace wowee