phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-05 04:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: Lua UnitIsAFK/UnitIsDND/UnitIsGhost/UnitIsPVPFreeForAll read wrong field

Browse source 
All four functions read UNIT_FIELD_FLAGS instead of PLAYER_FLAGS.
- AFK (0x01) hit UNIT_FLAG_SERVER_CONTROLLED — vendors flagged as AFK
- DND (0x02) hit UNIT_FLAG_NON_ATTACKABLE — guards flagged as DND
- Ghost (0x100) hit UNIT_FLAG_IMMUNE_TO_PC — immune NPCs flagged as ghost
- FFA PvP (0x80000) hit UNIT_FLAG_PACIFIED — pacified mobs flagged FFA

All now correctly read PLAYER_FLAGS with the right bit masks (0x01,
0x02, 0x10, 0x80 respectively), matching entity_controller.cpp which
already uses the correct field.
This commit is contained in:
Kelsi 2026-03-29 20:32:39 -07:00
parent f02be1ffac
commit b007a525a6
1 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/addons/lua_engine.cpp
View file

@ -378,8 +378,10 @@ static int lua_UnitIsGhost(lua_State* L) {
if (guid != 0) {
auto entity = gh->getEntityManager().getEntity(guid);
if (entity) {
uint32_t flags = entity->getField(game::fieldIndex(game::UF::UNIT_FIELD_FLAGS));
ghost = (flags & 0x00000100) != 0; // PLAYER_FLAGS_GHOST
// Ghost is PLAYER_FLAGS bit 0x10, NOT UNIT_FIELD_FLAGS bit 0x100
// (which is UNIT_FLAG_IMMUNE_TO_PC — would flag immune NPCs as ghosts).
uint32_t pf = entity->getField(game::fieldIndex(game::UF::PLAYER_FLAGS));
ghost = (pf & 0x00000010) != 0;
}
}
lua_pushboolean(L, ghost);
@ -413,8 +415,9 @@ static int lua_UnitIsAFK(lua_State* L) {
if (guid != 0) {
auto entity = gh->getEntityManager().getEntity(guid);
if (entity) {
// PLAYER_FLAGS at UNIT_FIELD_FLAGS: PLAYER_FLAGS_AFK = 0x01
uint32_t playerFlags = entity->getField(game::fieldIndex(game::UF::UNIT_FIELD_FLAGS));
// AFK is PLAYER_FLAGS bit 0x01, NOT UNIT_FIELD_FLAGS (where 0x01
// is UNIT_FLAG_SERVER_CONTROLLED — completely unrelated).
uint32_t playerFlags = entity->getField(game::fieldIndex(game::UF::PLAYER_FLAGS));
lua_pushboolean(L, (playerFlags & 0x01) != 0);
return 1;
}
@ -433,8 +436,9 @@ static int lua_UnitIsDND(lua_State* L) {
if (guid != 0) {
auto entity = gh->getEntityManager().getEntity(guid);
if (entity) {
uint32_t playerFlags = entity->getField(game::fieldIndex(game::UF::UNIT_FIELD_FLAGS));
lua_pushboolean(L, (playerFlags & 0x02) != 0); // PLAYER_FLAGS_DND
// DND is PLAYER_FLAGS bit 0x02, NOT UNIT_FIELD_FLAGS.
uint32_t playerFlags = entity->getField(game::fieldIndex(game::UF::PLAYER_FLAGS));
lua_pushboolean(L, (playerFlags & 0x02) != 0);
return 1;
}
}
@ -5139,9 +5143,10 @@ void LuaEngine::registerCoreAPI() {
if (guid == 0) { return luaReturnFalse(L); }
auto entity = gh->getEntityManager().getEntity(guid);
if (!entity) { return luaReturnFalse(L); }
// UNIT_FLAG_FFA_PVP = 0x00000080 in UNIT_FIELD_BYTES_2 byte 1
uint32_t flags = entity->getField(game::fieldIndex(game::UF::UNIT_FIELD_FLAGS));
lua_pushboolean(L, (flags & 0x00080000) ? 1 : 0); // PLAYER_FLAGS_FFA_PVP
// FFA PvP is PLAYER_FLAGS bit 0x80, NOT UNIT_FIELD_FLAGS bit 0x00080000
// (which is UNIT_FLAG_PACIFIED — would flag pacified mobs as FFA-PVP).
uint32_t pf = entity->getField(game::fieldIndex(game::UF::PLAYER_FLAGS));
lua_pushboolean(L, (pf & 0x00000080) ? 1 : 0);
return 1;
}},
{"GetBattlefieldStatus", [](lua_State* L) -> int {