phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: UnitIsDead falls back to party member stats for out-of-range units

Browse source 
Previously UnitIsDead returned false for out-of-range party members
(entity not in entity manager). Now checks curHealth==0 from
SMSG_PARTY_MEMBER_STATS data, so raid frame addons correctly show
dead members in other zones as dead.
This commit is contained in:
Kelsi 2026-03-21 09:23:20 -07:00
parent 4364fa7bbe
commit b1171327cb
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/addons/lua_engine.cpp
View file

@ -268,7 +268,17 @@ static int lua_UnitExists(lua_State* L) {
static int lua_UnitIsDead(lua_State* L) { static int lua_UnitIsDead(lua_State* L) {
const char* uid = luaL_optstring(L, 1, "player"); const char* uid = luaL_optstring(L, 1, "player");
auto* unit = resolveUnit(L, uid); auto* unit = resolveUnit(L, uid);
lua_pushboolean(L, unit && unit->getHealth() == 0); if (unit) {
lua_pushboolean(L, unit->getHealth() == 0);
} else {
// Fallback: party member stats for out-of-range members
auto* gh = getGameHandler(L);
std::string uidStr(uid);
for (char& c : uidStr) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
uint64_t guid = gh ? resolveUnitGuid(gh, uidStr) : 0;
const auto* pm = findPartyMember(gh, guid);
lua_pushboolean(L, pm ? (pm->curHealth == 0 && pm->maxHealth > 0) : 0);
}
return 1; return 1;
} }