phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Drive level-up effects from server packets instead of local field prediction

Browse source 
Switch level-up callback triggering to SMSG_LEVELUP_INFO/SMSG_LEVELUP_INFO_ALT so animation and SFX are server-authoritative.

Parse the new level directly from the level-up packet, update cached player/character level state, and fire callback only when level increases.

Remove duplicate callback firing from UNIT_FIELD_LEVEL update-field handling to prevent double-triggered level-up effects when values sync after the packet.
This commit is contained in:
Kelsi 2026-02-20 02:23:19 -08:00
parent 2ce8da52c6
commit b24703db30
1 changed files with 25 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/game/game_handler.cpp
View file

@ -1777,10 +1777,33 @@ void GameHandler::handlePacket(network::Packet& packet) {
case Opcode::SMSG_ENVIRONMENTALDAMAGELOG:
case Opcode::SMSG_SET_PROFICIENCY:
case Opcode::SMSG_ACTION_BUTTONS:
case Opcode::SMSG_LEVELUP_INFO:
case Opcode::SMSG_LEVELUP_INFO_ALT:
break;
case Opcode::SMSG_LEVELUP_INFO:
case Opcode::SMSG_LEVELUP_INFO_ALT: {
// Server-authoritative level-up event.
// First field is always the new level in Classic/TBC/WotLK-era layouts.
if (packet.getSize() - packet.getReadPos() >= 4) {
uint32_t newLevel = packet.readUInt32();
if (newLevel > 0) {
uint32_t oldLevel = serverPlayerLevel_;
serverPlayerLevel_ = std::max(serverPlayerLevel_, newLevel);
for (auto& ch : characters) {
if (ch.guid == playerGuid) {
ch.level = serverPlayerLevel_;
break;
}
}
if (newLevel > oldLevel && levelUpCallback_) {
levelUpCallback_(newLevel);
}
}
}
// Remaining payload (hp/mana/stat deltas) is optional for our client.
packet.setReadPos(packet.getSize());
break;
}
case Opcode::SMSG_PLAY_SOUND:
if (packet.getSize() - packet.getReadPos() >= 4) {
uint32_t soundId = packet.readUInt32();
@ -5121,7 +5144,6 @@ void GameHandler::handleUpdateObject(network::Packet& packet) {
LOG_INFO("Next level XP updated: ", val);
}
else if (key == ufPlayerLevel) {
uint32_t oldLevel = serverPlayerLevel_;
serverPlayerLevel_ = val;
LOG_INFO("Level updated: ", val);
for (auto& ch : characters) {
@ -5130,9 +5152,6 @@ void GameHandler::handleUpdateObject(network::Packet& packet) {
break;
}
}
if (val > oldLevel && oldLevel > 0 && levelUpCallback_) {
levelUpCallback_(val);
}
}
else if (key == ufCoinage) {
playerMoneyCopper_ = val;