phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-10 23:03:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: toLowerInPlace infinite recursion + remove redundant callback guards

Browse source 
Fix toLowerInPlace() which was accidentally self-recursive (would stack
overflow on any Lua string lowering). Remove 30 redundant
if(addonEventCallback_) wrappers around pure fireAddonEvent blocks.
Extract color constants in performance_hud.cpp (24 inline literals).
This commit is contained in:
Kelsi 2026-03-25 12:37:29 -07:00
parent b892dca0e5
commit b66033c6d8
3 changed files with 32 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/addons/lua_engine.cpp
View file

@ -22,7 +22,7 @@ extern "C" {
namespace wowee::addons {
static void toLowerInPlace(std::string& s) {
toLowerInPlace(s);
for (char& c : s) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
}
// Shared GetTime() epoch — all time-returning functions must use this same origin