phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-10 11:03:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat(editor): add --validate-wow weather schedule audit

Browse source 
Mirrors --validate-wol but for the .wow weather format. Walks
every entry and reports structural problems:

  • unknown weather typeId (above the Blizzard sentinel)
  • intensity bounds outside [0, 1] or min > max
  • non-positive weight (would zero a row in weighted-random
    selection and warp probabilities)
  • zero or inverted duration bounds
  • non-finite floats

Returns exit code 0 on PASS / 1 on FAIL — CI-friendly. JSON
output via --json for tooling.

All four built-in presets (--gen-weather-temperate / arctic /
desert / stormy) validate clean. The WOW format now has
parity with WOL on the inspect/validate front:

   WOL: --info-wol / --info-wol-at / --validate-wol
   WOW: --info-wow / --validate-wow

Milestone: kArgRequired now at 440 documented flags.
This commit is contained in:
Kelsi 2026-05-09 14:13:30 -07:00
parent 0a7c6c096d
commit bf8d37c145
3 changed files with 77 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tools/editor/cli_arg_required.cpp
View file

@ -17,7 +17,8 @@ const char* const kArgRequired[] = {
"--info-wob", "--info-wob-stats", "--info-woc", "--info-wot",
"--info-wol", "--info-wol-at", "--validate-wol", "--gen-light",
"--gen-light-cave", "--gen-light-dungeon", "--gen-light-night",
"--info-wow", "--gen-weather-temperate", "--gen-weather-arctic",
"--info-wow", "--validate-wow",
"--gen-weather-temperate", "--gen-weather-arctic",
"--gen-weather-desert", "--gen-weather-stormy",
"--info-creatures", "--info-objects", "--info-quests",
"--info-extract", "--info-extract-tree", "--info-extract-budget",

2
tools/editor/cli_help.cpp
View file

@ -795,6 +795,8 @@ void printUsage(const char* argv0) {
std::printf(" Emit a single-keyframe .wol with moonlit directional + far fog (always-night zone / shadow realm)\n");
std::printf(" --info-wow <wow-base> [--json]\n");
std::printf(" Print WOW weather entries (zone + per-state type / intensity / weight / duration) and exit\n");
std::printf(" --validate-wow <wow-base> [--json]\n");
std::printf(" Walk every WOW entry; check typeId / intensity bounds [0,1] / weight > 0 / duration min ≤ max\n");
std::printf(" --gen-weather-temperate <wow-base> [zoneName]\n");
std::printf(" Emit .wow weather schedule: clear-dominant + occasional rain + fog (forest / grassland)\n");
std::printf(" --gen-weather-arctic <wow-base> [zoneName]\n");

73
tools/editor/cli_world_info.cpp
View file

@ -582,6 +582,76 @@ int handleGenLightNight(int& i, int argc, char** argv) {
"moonlit directional + far fog");
}
int handleValidateWow(int& i, int argc, char** argv) {
// Walk every entry in a .wow and report structural problems:
// • unknown weather type id
// • intensity bounds out of [0, 1] or min > max
// • non-positive weight
// • duration bounds invalid (min > max, or = 0)
// • non-finite floats
// Returns 0 PASS / 1 FAIL.
std::string base = argv[++i];
bool jsonOut = (i + 1 < argc &&
std::strcmp(argv[i + 1], "--json") == 0);
if (jsonOut) ++i;
if (base.size() >= 4 && base.substr(base.size() - 4) == ".wow")
base = base.substr(0, base.size() - 4);
if (!wowee::pipeline::WoweeWeatherLoader::exists(base)) {
std::fprintf(stderr, "WOW not found: %s.wow\n", base.c_str());
return 1;
}
auto wow = wowee::pipeline::WoweeWeatherLoader::load(base);
std::vector<std::string> errors;
if (wow.entries.empty()) errors.push_back("no entries");
for (std::size_t k = 0; k < wow.entries.size(); ++k) {
const auto& e = wow.entries[k];
const std::string ks = std::to_string(k);
if (e.weatherTypeId > wowee::pipeline::WoweeWeather::Blizzard) {
errors.push_back("entry " + ks + " unknown typeId " +
std::to_string(e.weatherTypeId));
}
if (!std::isfinite(e.minIntensity) ||
!std::isfinite(e.maxIntensity)) {
errors.push_back("entry " + ks + " intensity not finite");
}
if (e.minIntensity < 0.0f || e.maxIntensity > 1.0f) {
errors.push_back("entry " + ks + " intensity outside [0,1]");
}
if (e.minIntensity > e.maxIntensity) {
errors.push_back("entry " + ks + " minIntensity > maxIntensity");
}
if (!std::isfinite(e.weight) || e.weight <= 0.0f) {
errors.push_back("entry " + ks + " weight " +
std::to_string(e.weight) + " <= 0");
}
if (e.maxDurationSec == 0) {
errors.push_back("entry " + ks + " maxDurationSec is 0");
}
if (e.minDurationSec > e.maxDurationSec) {
errors.push_back("entry " + ks +
" minDurationSec > maxDurationSec");
}
}
if (jsonOut) {
nlohmann::json j;
j["wow"] = base + ".wow";
j["passed"] = errors.empty();
j["errorCount"] = errors.size();
j["errors"] = errors;
std::printf("%s\n", j.dump(2).c_str());
return errors.empty() ? 0 : 1;
}
if (errors.empty()) {
std::printf("WOW %s.wow PASSED — %zu entry/entries valid\n",
base.c_str(), wow.entries.size());
return 0;
}
std::printf("WOW %s.wow FAILED — %zu error(s):\n",
base.c_str(), errors.size());
for (const auto& e : errors) std::printf(" - %s\n", e.c_str());
return 1;
}
int handleInfoWow(int& i, int argc, char** argv) {
// Inspect a Wowee Open Weather (.wow) file: zone name +
// per-entry weather type + intensity bounds + selection
@ -732,6 +802,9 @@ bool handleWorldInfo(int& i, int argc, char** argv, int& outRc) {
if (std::strcmp(argv[i], "--info-wow") == 0 && i + 1 < argc) {
outRc = handleInfoWow(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--validate-wow") == 0 && i + 1 < argc) {
outRc = handleValidateWow(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--gen-weather-temperate") == 0 && i + 1 < argc) {
outRc = handleGenWeatherTemperate(i, argc, argv); return true;
}