phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-16 17:13:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

cleanup: remove misleading (void)flags — variable IS used for crit check

Browse source 
The cast falsely suggests flags is unused but it's read on the next
line for isCrit = (flags & 0x02). Also inlines the periodicLog discard.
This commit is contained in:
Kelsi 2026-03-29 20:05:45 -07:00
parent 568a14852d
commit c1f6364814
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/game/world_packets.cpp
View file

@ -3533,13 +3533,10 @@ bool SpellDamageLogParser::parse(network::Packet& packet, SpellDamageLogData& da
return false;
}
uint8_t periodicLog = packet.readUInt8();
(void)periodicLog;
(void)packet.readUInt8(); // periodicLog (not displayed)
packet.readUInt8(); // unused
packet.readUInt32(); // blocked
uint32_t flags = packet.readUInt32();
(void)flags;
// Check crit flag
uint32_t flags = packet.readUInt32(); // flags IS used — bit 0x02 = crit
data.isCrit = (flags & 0x02) != 0;
LOG_DEBUG("Spell damage: spellId=", data.spellId, " dmg=", data.damage,