phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-26 00:40:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat: add achievement API (GetAchievementInfo, GetNumCompleted)

Browse source 
GetNumCompletedAchievements() returns count of earned achievements.
GetAchievementInfo(id) returns the full 12-field WoW API signature:
id, name, points, completed, month, day, year, description, flags,
icon, rewardText, isGuildAchievement.

Uses existing earnedAchievements_ set, achievement name/description/
points caches from Achievement.dbc, and completion date tracking
from SMSG_ALL_ACHIEVEMENT_DATA / SMSG_ACHIEVEMENT_EARNED.

Enables achievement tracking addons (Overachiever, etc.) to query
and display achievement progress.
This commit is contained in:
Kelsi 2026-03-22 22:43:10 -07:00
parent ee6551b286
commit c25151eff1
1 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

35
src/addons/lua_engine.cpp
View file

@ -5062,6 +5062,41 @@ void LuaEngine::registerCoreAPI() {
lua_pushboolean(L, 1); // isCastable
return 4;
}},
// --- Achievement API ---
{"GetNumCompletedAchievements", [](lua_State* L) -> int {
auto* gh = getGameHandler(L);
lua_pushnumber(L, gh ? gh->getEarnedAchievements().size() : 0);
return 1;
}},
{"GetAchievementInfo", [](lua_State* L) -> int {
// GetAchievementInfo(id) → id, name, points, completed, month, day, year, description, flags, icon, rewardText, isGuildAch
auto* gh = getGameHandler(L);
uint32_t id = static_cast<uint32_t>(luaL_checknumber(L, 1));
if (!gh) { lua_pushnil(L); return 1; }
const std::string& name = gh->getAchievementName(id);
if (name.empty()) { lua_pushnil(L); return 1; }
bool completed = gh->getEarnedAchievements().count(id) > 0;
uint32_t date = gh->getAchievementDate(id);
uint32_t points = gh->getAchievementPoints(id);
const std::string& desc = gh->getAchievementDescription(id);
// Parse date: packed as (month << 24 | day << 16 | year)
int month = completed ? static_cast<int>((date >> 24) & 0xFF) : 0;
int day = completed ? static_cast<int>((date >> 16) & 0xFF) : 0;
int year = completed ? static_cast<int>(date & 0xFFFF) : 0;
lua_pushnumber(L, id); // 1: id
lua_pushstring(L, name.c_str()); // 2: name
lua_pushnumber(L, points); // 3: points
lua_pushboolean(L, completed ? 1 : 0); // 4: completed
lua_pushnumber(L, month); // 5: month
lua_pushnumber(L, day); // 6: day
lua_pushnumber(L, year); // 7: year
lua_pushstring(L, desc.c_str()); // 8: description
lua_pushnumber(L, 0); // 9: flags
lua_pushstring(L, "Interface\\Icons\\Achievement_General"); // 10: icon
lua_pushstring(L, ""); // 11: rewardText
lua_pushboolean(L, 0); // 12: isGuildAchievement
return 12;
}},
// --- Pet Action Bar ---
{"HasPetUI", [](lua_State* L) -> int {
auto* gh = getGameHandler(L);