phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-23 07:40:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

apply pending protocol, ui, audio, and CodeQL fixes

Browse source
This commit is contained in:
Kelsi 2026-02-19 16:17:06 -08:00
parent 586fb88c5f
commit c69457ae3b
14 changed files with 276 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/network/world_socket.cpp
View file

@ -443,7 +443,11 @@ void WorldSocket::initEncryption(const std::vector<uint8_t>& sessionKey, uint32_
std::vector<uint8_t> encryptHash = auth::Crypto::hmacSHA1(encryptKey, sessionKey);
std::vector<uint8_t> decryptHash = auth::Crypto::hmacSHA1(decryptKey, sessionKey);
// lgtm [cpp/weak-cryptographic-algorithm]
// WoW WotLK world-header stream cipher is protocol-defined RC4.
// Replacing it would break interoperability with target servers.
encryptCipher.init(encryptHash);
// lgtm [cpp/weak-cryptographic-algorithm]
decryptCipher.init(decryptHash);
// Drop first 1024 bytes of keystream (WoW WotLK protocol requirement)