phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix quest turn-in loop and register SMSG_CANCEL_AUTO_REPEAT

Browse source 
The gossip questIcon field is an integer enum (2=available, 4=incomplete,
5=ready-to-turn-in), not a bitmask. Using (questIcon & 0x04) caused icon=4
(in-progress quests) to be treated as completable, so the client sent
CMSG_QUESTGIVER_REQUEST_REWARD for incomplete quests. The server rejected
these silently and re-sent SMSG_GOSSIP_MESSAGE, causing an infinite loop.

Fix: use exact equality (questIcon == 5 for completable, == 4 for incomplete).

Also register SMSG_CANCEL_AUTO_REPEAT (0x06B) to suppress the unhandled
opcode warning logged on every login.
This commit is contained in:
Kelsi 2026-02-17 15:57:51 -08:00
parent 55fd692c1a
commit ca3cf209d9
3 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/game/opcode_table.hpp
View file

@ -187,6 +187,7 @@ enum class LogicalOpcode : uint16_t {
SMSG_REMOVED_SPELL,
SMSG_SEND_UNLEARN_SPELLS,
SMSG_SPELL_DELAYED,
SMSG_CANCEL_AUTO_REPEAT,
SMSG_AURA_UPDATE,
SMSG_AURA_UPDATE_ALL,
SMSG_SET_FLAT_SPELL_MODIFIER,