From cabf897683fbf8d4c317eb5ef21dd9a1a6fb488a Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Wed, 18 Feb 2026 23:48:11 -0800
Subject: [PATCH] Ignore zero-id forced quest removals to prevent spawn spam

---
 src/game/game_handler.cpp | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp
index f4d3adc1..0de4f9ab 100644
--- a/src/game/game_handler.cpp
+++ b/src/game/game_handler.cpp
@@ -1764,30 +1764,43 @@ void GameHandler::handlePacket(network::Packet& packet) {
                 break;
             }
             uint32_t questId = packet.readUInt32();
+            if (questId == 0) {
+                // Some servers emit a zero-id variant during world bootstrap.
+                // Treat as no-op to avoid false "Quest removed" spam.
+                break;
+            }
+
+            bool removed = false;
             std::string removedTitle;
             for (auto it = questLog_.begin(); it != questLog_.end(); ++it) {
                 if (it->questId == questId) {
                     removedTitle = it->title;
                     questLog_.erase(it);
+                    removed = true;
                     break;
                 }
             }
             if (currentQuestDetails.questId == questId) {
                 questDetailsOpen = false;
                 currentQuestDetails = QuestDetailsData{};
+                removed = true;
             }
             if (currentQuestRequestItems_.questId == questId) {
                 questRequestItemsOpen_ = false;
                 currentQuestRequestItems_ = QuestRequestItemsData{};
+                removed = true;
             }
             if (currentQuestOfferReward_.questId == questId) {
                 questOfferRewardOpen_ = false;
                 currentQuestOfferReward_ = QuestOfferRewardData{};
+                removed = true;
             }
-            if (!removedTitle.empty()) {
-                addSystemChatMessage("Quest removed: " + removedTitle);
-            } else {
-                addSystemChatMessage("Quest removed (ID " + std::to_string(questId) + ").");
+            if (removed) {
+                if (!removedTitle.empty()) {
+                    addSystemChatMessage("Quest removed: " + removedTitle);
+                } else {
+                    addSystemChatMessage("Quest removed (ID " + std::to_string(questId) + ").");
+                }
             }
             break;
         }