From cf88a960f48f0081683b8bf497fae00eb2b43650 Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Fri, 13 Mar 2026 06:48:12 -0700
Subject: [PATCH] feat: add missing SMSG_CHANNEL_NOTIFY feedback for 12
 unhandled notification types

Previously, PLAYER_NOT_FOUND, ANNOUNCEMENTS_ON/OFF, MODERATION_ON/OFF,
PLAYER_BANNED, PLAYER_UNBANNED, PLAYER_NOT_BANNED, INVITE, WRONG_FACTION,
INVITE_WRONG_FACTION, NOT_MODERATED, PLAYER_INVITED, and PLAYER_INVITE_BANNED
all fell silently to the default log-only path. Now each shows an appropriate
system message in chat.
---
 src/game/game_handler.cpp | 40 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp
index 48527d8e..36fe34c9 100644
--- a/src/game/game_handler.cpp
+++ b/src/game/game_handler.cpp
@@ -11304,6 +11304,46 @@ void GameHandler::handleChannelNotify(network::Packet& packet) {
         case ChannelNotifyType::INVALID_NAME:
             addSystemChatMessage("Invalid channel name '" + data.channelName + "'.");
             break;
+        case ChannelNotifyType::PLAYER_NOT_FOUND:
+            addSystemChatMessage("Player not found.");
+            break;
+        case ChannelNotifyType::ANNOUNCEMENTS_ON:
+            addSystemChatMessage("Channel '" + data.channelName + "': announcements enabled.");
+            break;
+        case ChannelNotifyType::ANNOUNCEMENTS_OFF:
+            addSystemChatMessage("Channel '" + data.channelName + "': announcements disabled.");
+            break;
+        case ChannelNotifyType::MODERATION_ON:
+            addSystemChatMessage("Channel '" + data.channelName + "' is now moderated.");
+            break;
+        case ChannelNotifyType::MODERATION_OFF:
+            addSystemChatMessage("Channel '" + data.channelName + "' is no longer moderated.");
+            break;
+        case ChannelNotifyType::PLAYER_BANNED:
+            addSystemChatMessage("A player was banned from '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::PLAYER_UNBANNED:
+            addSystemChatMessage("A player was unbanned from '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::PLAYER_NOT_BANNED:
+            addSystemChatMessage("That player is not banned from '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::INVITE:
+            addSystemChatMessage("You have been invited to join channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::INVITE_WRONG_FACTION:
+        case ChannelNotifyType::WRONG_FACTION:
+            addSystemChatMessage("Wrong faction for channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::NOT_MODERATED:
+            addSystemChatMessage("Channel '" + data.channelName + "' is not moderated.");
+            break;
+        case ChannelNotifyType::PLAYER_INVITED:
+            addSystemChatMessage("Player invited to channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::PLAYER_INVITE_BANNED:
+            addSystemChatMessage("That player is banned from '" + data.channelName + "'.");
+            break;
         default:
             LOG_DEBUG("Channel notify type ", static_cast<int>(data.notifyType),
                      " for channel ", data.channelName);