From d1bcd2f8441fe04c4adeb7c7712cfabcdede49cb Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Fri, 20 Mar 2026 15:53:43 -0700
Subject: [PATCH] fix: resolve compiler warnings in lua_engine and game_screen

Remove unused getPlayerUnit() helper in lua_engine.cpp (-Wunused-function).
Increase countStr buffer from 8 to 16 bytes in action bar item count
display to eliminate -Wformat-truncation warning for %d with int32_t.
Build is now warning-free.
---
 src/addons/lua_engine.cpp | 9 ---------
 src/ui/game_screen.cpp    | 2 +-
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/addons/lua_engine.cpp b/src/addons/lua_engine.cpp
index 1e676fad..76149dfd 100644
--- a/src/addons/lua_engine.cpp
+++ b/src/addons/lua_engine.cpp
@@ -59,15 +59,6 @@ static int lua_wow_message(lua_State* L) {
     return lua_wow_print(L);
 }
 
-// Helper: get player Unit from game handler
-static game::Unit* getPlayerUnit(lua_State* L) {
-    auto* gh = getGameHandler(L);
-    if (!gh) return nullptr;
-    auto entity = gh->getEntityManager().getEntity(gh->getPlayerGuid());
-    if (!entity) return nullptr;
-    return dynamic_cast<game::Unit*>(entity.get());
-}
-
 // Helper: resolve WoW unit IDs to GUID
 static uint64_t resolveUnitGuid(game::GameHandler* gh, const std::string& uid) {
     if (uid == "player")      return gh->getPlayerGuid();
diff --git a/src/ui/game_screen.cpp b/src/ui/game_screen.cpp
index 1d36fb26..f17188e9 100644
--- a/src/ui/game_screen.cpp
+++ b/src/ui/game_screen.cpp
@@ -9412,7 +9412,7 @@ void GameScreen::renderActionBar(game::GameHandler& gameHandler) {
                 }
             }
             if (totalCount > 0) {
-                char countStr[8];
+                char countStr[16];
                 snprintf(countStr, sizeof(countStr), "%d", totalCount);
                 ImVec2 btnMax = ImGui::GetItemRectMax();
                 ImVec2 tsz = ImGui::CalcTextSize(countStr);