phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-06 17:13:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(wom): sanitize boundRadius/min/max floats at save time

Browse source 
Mirrors the WHM and WOC save sanitize. boundRadius defaults to 1.0 if
non-finite (matches load-time default); boundMin/boundMax components
zero out non-finite values. Prevents an in-memory model with a NaN
spike (e.g. mid-edit) from being persisted into the WOM and requiring
load-time cleanup forever after.
This commit is contained in:
Kelsi 2026-05-06 06:36:46 -07:00
parent 663d34af0d
commit d25654d11a
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/pipeline/wowee_model.cpp
View file

@ -261,9 +261,21 @@ bool WoweeModelLoader::save(const WoweeModel& model, const std::string& basePath
f.write(reinterpret_cast<const char*>(&vertCount), 4);
f.write(reinterpret_cast<const char*>(&indexCount), 4);
f.write(reinterpret_cast<const char*>(&texCount), 4);
f.write(reinterpret_cast<const char*>(&model.boundRadius), 4);
f.write(reinterpret_cast<const char*>(&model.boundMin), 12);
f.write(reinterpret_cast<const char*>(&model.boundMax), 12);
// Sanitize bound floats at save time; matches the load-time guard so a
// partial-write or in-memory corruption can't poison the file.
float boundRadius = std::isfinite(model.boundRadius) && model.boundRadius >= 0.0f
? model.boundRadius : 1.0f;
glm::vec3 boundMin = model.boundMin, boundMax = model.boundMax;
auto sanVec3 = [](glm::vec3& v) {
if (!std::isfinite(v.x)) v.x = 0.0f;
if (!std::isfinite(v.y)) v.y = 0.0f;
if (!std::isfinite(v.z)) v.z = 0.0f;
};
sanVec3(boundMin);
sanVec3(boundMax);
f.write(reinterpret_cast<const char*>(&boundRadius), 4);
f.write(reinterpret_cast<const char*>(&boundMin), 12);
f.write(reinterpret_cast<const char*>(&boundMax), 12);
// Same writeStr pattern as WoB: truncate to 1KB so the u16 length doesn't
// wrap and corrupt the rest of the file.