phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-14 08:23:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: restore Classic aura flag normalization and clean up EntityController

Browse source 
- Restore 0x02→0x80 Classic harmful-to-WotLK debuff bit mapping in
  syncClassicAurasFromFields so downstream checks work across expansions
- Extract handleDisplayIdChange helper to deduplicate identical logic
  in onValuesUpdateUnit and onValuesUpdatePlayer
- Remove unused newItemCreated parameter from handleValuesUpdate
- Fix indentation on PLAYER_DEAD/PLAYER_ALIVE/PLAYER_UNGHOST emit calls
This commit is contained in:
Kelsi 2026-03-29 16:29:56 -07:00
parent 1988b53619
commit d32b35c583
2 changed files with 42 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

6
include/game/entity_controller.hpp
View file

@ -152,7 +152,7 @@ private:
// --- Phase 2: Update type handlers ---
void handleCreateObject(const UpdateBlock& block, bool& newItemCreated);
void handleValuesUpdate(const UpdateBlock& block, bool& newItemCreated);
void handleValuesUpdate(const UpdateBlock& block);
void handleMovementUpdate(const UpdateBlock& block);
// --- Phase 3: Concern-specific helpers ---
@ -253,6 +253,10 @@ private:
void onCreateGameObject(const UpdateBlock& block, std::shared_ptr<Entity>& entity);
void onCreateItem(const UpdateBlock& block, bool& newItemCreated);
void onCreateCorpse(const UpdateBlock& block);
void handleDisplayIdChange(const UpdateBlock& block,
const std::shared_ptr<Entity>& entity,
const std::shared_ptr<Unit>& unit,
const UnitFieldUpdateResult& result);
void onValuesUpdateUnit(const UpdateBlock& block, std::shared_ptr<Entity>& entity);
void onValuesUpdatePlayer(const UpdateBlock& block, std::shared_ptr<Entity>& entity);
void onValuesUpdateItem(const UpdateBlock& block, std::shared_ptr<Entity>& entity);