From d48e4fb7c322db1ff2911146ade1b7406a6d0b9f Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Thu, 12 Mar 2026 12:32:19 -0700
Subject: [PATCH] feat: resolve enchant names from SpellItemEnchantment.dbc in
 inspect window

---
 Data/expansions/tbc/dbc_layouts.json    |  3 +++
 Data/expansions/turtle/dbc_layouts.json |  3 +++
 Data/expansions/wotlk/dbc_layouts.json  |  3 +++
 src/ui/game_screen.cpp                  | 36 ++++++++++++++++++++++---
 4 files changed, 42 insertions(+), 3 deletions(-)

diff --git a/Data/expansions/tbc/dbc_layouts.json b/Data/expansions/tbc/dbc_layouts.json
index b99159a6..9ada081b 100644
--- a/Data/expansions/tbc/dbc_layouts.json
+++ b/Data/expansions/tbc/dbc_layouts.json
@@ -97,5 +97,8 @@
     "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
     "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
     "DisplayMapID": 8, "ParentWorldMapID": 10
+  },
+  "SpellItemEnchantment": {
+    "ID": 0, "Name": 8
   }
 }
diff --git a/Data/expansions/turtle/dbc_layouts.json b/Data/expansions/turtle/dbc_layouts.json
index 3b06971d..beaa0c6c 100644
--- a/Data/expansions/turtle/dbc_layouts.json
+++ b/Data/expansions/turtle/dbc_layouts.json
@@ -95,5 +95,8 @@
     "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
     "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
     "DisplayMapID": 8, "ParentWorldMapID": 10
+  },
+  "SpellItemEnchantment": {
+    "ID": 0, "Name": 8
   }
 }
diff --git a/Data/expansions/wotlk/dbc_layouts.json b/Data/expansions/wotlk/dbc_layouts.json
index 94f7df4d..3c4ec125 100644
--- a/Data/expansions/wotlk/dbc_layouts.json
+++ b/Data/expansions/wotlk/dbc_layouts.json
@@ -98,5 +98,8 @@
     "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
     "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
     "DisplayMapID": 8, "ParentWorldMapID": 10
+  },
+  "SpellItemEnchantment": {
+    "ID": 0, "Name": 8
   }
 }
diff --git a/src/ui/game_screen.cpp b/src/ui/game_screen.cpp
index 33e78f25..0f4c0b96 100644
--- a/src/ui/game_screen.cpp
+++ b/src/ui/game_screen.cpp
@@ -17996,6 +17996,28 @@ void GameScreen::renderObjectiveTracker(game::GameHandler& gameHandler) {
 void GameScreen::renderInspectWindow(game::GameHandler& gameHandler) {
     if (!showInspectWindow_) return;
 
+    // Lazy-load SpellItemEnchantment.dbc for enchant name lookup
+    static std::unordered_map<uint32_t, std::string> s_enchantNames;
+    static bool s_enchantDbLoaded = false;
+    auto* assetMgrEnchant = core::Application::getInstance().getAssetManager();
+    if (!s_enchantDbLoaded && assetMgrEnchant && assetMgrEnchant->isInitialized()) {
+        s_enchantDbLoaded = true;
+        auto dbc = assetMgrEnchant->loadDBC("SpellItemEnchantment.dbc");
+        if (dbc && dbc->isLoaded()) {
+            const auto* layout = pipeline::getActiveDBCLayout()
+                                 ? pipeline::getActiveDBCLayout()->getLayout("SpellItemEnchantment")
+                                 : nullptr;
+            uint32_t idField   = layout ? (*layout)["ID"]   : 0;
+            uint32_t nameField = layout ? (*layout)["Name"] : 8;
+            for (uint32_t i = 0; i < dbc->getRecordCount(); ++i) {
+                uint32_t id = dbc->getUInt32(i, idField);
+                if (id == 0) continue;
+                std::string nm = dbc->getString(i, nameField);
+                if (!nm.empty()) s_enchantNames[id] = std::move(nm);
+            }
+        }
+    }
+
     // Slot index 0..18 maps to equipment slots 1..19 (WoW convention: slot 0 unused on server)
     static const char* kSlotNames[19] = {
         "Head", "Neck", "Shoulder", "Shirt", "Chest",
@@ -18122,10 +18144,18 @@ void GameScreen::renderInspectWindow(game::GameHandler& gameHandler) {
                 ImGui::TextColored(qColor, "%s", info->name.c_str());
                 // Enchant indicator on the same row as the name
                 if (enchantId != 0) {
+                    auto enchIt = s_enchantNames.find(enchantId);
+                    const std::string& enchName = (enchIt != s_enchantNames.end())
+                                                  ? enchIt->second : std::string{};
                     ImGui::SameLine();
-                    ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f), "\xe2\x9c\xa6");  // UTF-8 ✦
-                    if (ImGui::IsItemHovered())
-                        ImGui::SetTooltip("Enchanted (ID %u)", static_cast<unsigned>(enchantId));
+                    if (!enchName.empty()) {
+                        ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f),
+                            "\xe2\x9c\xa6 %s", enchName.c_str());  // UTF-8 ✦
+                    } else {
+                        ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f), "\xe2\x9c\xa6");
+                        if (ImGui::IsItemHovered())
+                            ImGui::SetTooltip("Enchanted (ID %u)", static_cast<unsigned>(enchantId));
+                    }
                 }
                 ImGui::EndGroup();
                 hovered = hovered || ImGui::IsItemHovered();