phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-26 16:50:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor: add fireAddonEvent() helper to eliminate 170+ null checks

Browse source 
Add inline fireAddonEvent() that wraps the addonEventCallback_ null
check. Replace ~120 direct addonEventCallback_ calls with fireAddonEvent,
eliminating redundant null checks at each callsite and reducing
boilerplate by ~30 lines.
This commit is contained in:
Kelsi 2026-03-25 11:34:22 -07:00
parent 98b9e502c5
commit d646a0451d
2 changed files with 246 additions and 277 deletions
Download patch file Download diff file Expand all files Collapse all files

9
include/game/game_handler.hpp
View file

@ -1310,7 +1310,7 @@ public:
// Barber shop
bool isBarberShopOpen() const { return barberShopOpen_; }
void closeBarberShop() { barberShopOpen_ = false; if (addonEventCallback_) addonEventCallback_("BARBER_SHOP_CLOSE", {}); }
void closeBarberShop() { barberShopOpen_ = false; fireAddonEvent("BARBER_SHOP_CLOSE", {}); }
void sendAlterAppearance(uint32_t hairStyle, uint32_t hairColor, uint32_t facialHair);
// Instance difficulty (0=5N, 1=5H, 2=25N, 3=25H for WotLK)
@ -1992,10 +1992,13 @@ public:
void setUIErrorCallback(UIErrorCallback cb) { uiErrorCallback_ = std::move(cb); }
void addUIError(const std::string& msg) {
if (uiErrorCallback_) uiErrorCallback_(msg);
if (addonEventCallback_) addonEventCallback_("UI_ERROR_MESSAGE", {msg});
fireAddonEvent("UI_ERROR_MESSAGE", {msg});
}
void addUIInfoMessage(const std::string& msg) {
if (addonEventCallback_) addonEventCallback_("UI_INFO_MESSAGE", {msg});
fireAddonEvent("UI_INFO_MESSAGE", {msg});
}
void fireAddonEvent(const std::string& event, const std::vector<std::string>& args = {}) {
if (addonEventCallback_) addonEventCallback_(event, args);
}
// Reputation change toast: factionName, delta, new standing