From d79c79e1bc67a8af50dcf1966844deba703b8dee Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Fri, 13 Mar 2026 06:18:23 -0700
Subject: [PATCH] feat: show chat messages for channel notification events

SMSG_CHANNEL_NOTIFY carries many event types that were silently dropped
in the default case: wrong password, muted, banned, throttled, kicked,
not owner, not moderator, password changed, owner changed, invalid name,
not in area, not in LFG. These are now surfaced as system chat messages
matching WoW-standard phrasing.
---
 src/game/game_handler.cpp | 40 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp
index 45e6f107..08623dc3 100644
--- a/src/game/game_handler.cpp
+++ b/src/game/game_handler.cpp
@@ -11228,10 +11228,46 @@ void GameHandler::handleChannelNotify(network::Packet& packet) {
             }
             break;
         }
-        case ChannelNotifyType::NOT_IN_AREA: {
+        case ChannelNotifyType::NOT_IN_AREA:
+            addSystemChatMessage("You must be in the area to join '" + data.channelName + "'.");
             LOG_DEBUG("Cannot join channel ", data.channelName, " (not in area)");
             break;
-        }
+        case ChannelNotifyType::WRONG_PASSWORD:
+            addSystemChatMessage("Wrong password for channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::NOT_MEMBER:
+            addSystemChatMessage("You are not in channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::NOT_MODERATOR:
+            addSystemChatMessage("You are not a moderator of '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::MUTED:
+            addSystemChatMessage("You are muted in channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::BANNED:
+            addSystemChatMessage("You are banned from channel '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::THROTTLED:
+            addSystemChatMessage("Channel '" + data.channelName + "' is throttled. Please wait.");
+            break;
+        case ChannelNotifyType::NOT_IN_LFG:
+            addSystemChatMessage("You must be in a LFG queue to join '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::PLAYER_KICKED:
+            addSystemChatMessage("A player was kicked from '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::PASSWORD_CHANGED:
+            addSystemChatMessage("Password for '" + data.channelName + "' changed.");
+            break;
+        case ChannelNotifyType::OWNER_CHANGED:
+            addSystemChatMessage("Owner of '" + data.channelName + "' changed.");
+            break;
+        case ChannelNotifyType::NOT_OWNER:
+            addSystemChatMessage("You are not the owner of '" + data.channelName + "'.");
+            break;
+        case ChannelNotifyType::INVALID_NAME:
+            addSystemChatMessage("Invalid channel name '" + data.channelName + "'.");
+            break;
         default:
             LOG_DEBUG("Channel notify type ", static_cast<int>(data.notifyType),
                      " for channel ", data.channelName);