From dd8c2cbb203d1732d7e25909f42330957ed5e2ca Mon Sep 17 00:00:00 2001 From: Kelsi Date: Tue, 10 Mar 2026 04:48:33 -0700 Subject: [PATCH] game: downgrade per-item-query LOG_INFO to LOG_DEBUG in game_handler MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit queryItemInfo and handleItemQueryResponse fire for every item in inventory, loot windows, vendor lists, and mail — potentially dozens of times at login or when any container is opened. Downgrade to LOG_DEBUG to reduce noise. Also downgrade useItemById search traces to LOG_DEBUG; the final warning (item not found) stays at LOG_WARNING. --- src/game/game_handler.cpp | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp index 45969ae6..fc5cc0b1 100644 --- a/src/game/game_handler.cpp +++ b/src/game/game_handler.cpp @@ -10044,8 +10044,8 @@ void GameHandler::queryItemInfo(uint32_t entry, uint64_t guid) { ? packetParsers_->buildItemQuery(entry, queryGuid) : ItemQueryPacket::build(entry, queryGuid); socket->send(packet); - LOG_INFO("queryItemInfo: entry=", entry, " guid=0x", std::hex, queryGuid, std::dec, - " pending=", pendingItemQueries_.size()); + LOG_DEBUG("queryItemInfo: entry=", entry, " guid=0x", std::hex, queryGuid, std::dec, + " pending=", pendingItemQueries_.size()); } void GameHandler::handleItemQueryResponse(network::Packet& packet) { @@ -10059,9 +10059,8 @@ void GameHandler::handleItemQueryResponse(network::Packet& packet) { } pendingItemQueries_.erase(data.entry); - LOG_INFO("handleItemQueryResponse: entry=", data.entry, " valid=", data.valid, - " name='", data.name, "' displayInfoId=", data.displayInfoId, - " pending=", pendingItemQueries_.size()); + LOG_DEBUG("handleItemQueryResponse: entry=", data.entry, " name='", data.name, + "' displayInfoId=", data.displayInfoId, " pending=", pendingItemQueries_.size()); if (data.valid) { itemInfoCache_[data.entry] = data; @@ -14694,12 +14693,12 @@ void GameHandler::useItemInBag(int bagIndex, int slotIndex) { void GameHandler::useItemById(uint32_t itemId) { if (itemId == 0) return; - LOG_INFO("useItemById: searching for itemId=", itemId, " in backpack (", inventory.getBackpackSize(), " slots)"); + LOG_DEBUG("useItemById: searching for itemId=", itemId); // Search backpack first for (int i = 0; i < inventory.getBackpackSize(); i++) { const auto& slot = inventory.getBackpackSlot(i); if (!slot.empty() && slot.item.itemId == itemId) { - LOG_INFO("useItemById: found itemId=", itemId, " at backpack slot ", i); + LOG_DEBUG("useItemById: found itemId=", itemId, " at backpack slot ", i); useItemBySlot(i); return; } @@ -14710,7 +14709,7 @@ void GameHandler::useItemById(uint32_t itemId) { for (int slot = 0; slot < bagSize; slot++) { const auto& bagSlot = inventory.getBagSlot(bag, slot); if (!bagSlot.empty() && bagSlot.item.itemId == itemId) { - LOG_INFO("useItemById: found itemId=", itemId, " in bag ", bag, " slot ", slot); + LOG_DEBUG("useItemById: found itemId=", itemId, " in bag ", bag, " slot ", slot); useItemInBag(bag, slot); return; }