phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-23 07:40:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

game: fix expansion-gated GUIDs for PARTY_MEMBER_STATS and MINIMAP_PING

Browse source
This commit is contained in:
Kelsi 2026-03-09 23:53:43 -07:00
parent e122d725f6
commit deea701222
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/game/game_handler.cpp
View file

@ -2646,9 +2646,12 @@ void GameHandler::handlePacket(network::Packet& packet) {
addSystemChatMessage("Your fish escaped!");
break;
case Opcode::MSG_MINIMAP_PING: {
// SMSG: packed_guid + float posX (canonical WoW Y=west) + float posY (canonical WoW X=north)
if (packet.getSize() - packet.getReadPos() < 1) break;
uint64_t senderGuid = UpdateObjectParser::readPackedGuid(packet);
// WotLK: packed_guid + float posX + float posY
// TBC/Classic: uint64 + float posX + float posY
const bool mmTbcLike = isClassicLikeExpansion() || isActiveExpansion("tbc");
if (packet.getSize() - packet.getReadPos() < (mmTbcLike ? 8u : 1u)) break;
uint64_t senderGuid = mmTbcLike
? packet.readUInt64() : UpdateObjectParser::readPackedGuid(packet);
if (packet.getSize() - packet.getReadPos() < 8) break;
float pingX = packet.readFloat(); // server sends map-coord X (east-west)
float pingY = packet.readFloat(); // server sends map-coord Y (north-south)
@ -13259,7 +13262,11 @@ void GameHandler::handlePartyMemberStats(network::Packet& packet, bool isFull) {
packet.readUInt8();
}
uint64_t memberGuid = UpdateObjectParser::readPackedGuid(packet);
// WotLK uses packed GUID; TBC/Classic use full uint64
const bool pmsTbcLike = isClassicLikeExpansion() || isActiveExpansion("tbc");
if (remaining() < (pmsTbcLike ? 8u : 1u)) return;
uint64_t memberGuid = pmsTbcLike
? packet.readUInt64() : UpdateObjectParser::readPackedGuid(packet);
if (remaining() < 4) return;
uint32_t updateFlags = packet.readUInt32();