From e029e8649f27597168bcbc35d8af35d28a70d26f Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Thu, 12 Mar 2026 22:53:33 -0700
Subject: [PATCH] feat: parse SMSG_SPELLLOGEXECUTE CREATE_ITEM effects for
 profession crafting feedback

- Implement SMSG_SPELLLOGEXECUTE handler with expansion-aware caster GUID reading
  (packed_guid for WotLK/Classic, full uint64 for TBC)
- Parse effect type 24 (SPELL_EFFECT_CREATE_ITEM): show "You create <item> using
  <spell>." in chat when the player uses a profession or any create-item spell
- Look up item name via ensureItemInfo/getItemInfo and spell name via spellNameCache_
- Fall back to "You create: <item>." when the spell name is not cached
- Safely consume unknown effect types by stopping parse at first unrecognized effect
  to avoid packet misalignment on variable-length sub-records
- Adds visible crafting feedback complementary to SMSG_ITEM_PUSH_RESULT (which shows
  "Received:" for looted/obtained items) with a profession-specific "create" message
---
 src/game/game_handler.cpp | 59 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 58 insertions(+), 1 deletion(-)

diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp
index 92406bef..a87960a7 100644
--- a/src/game/game_handler.cpp
+++ b/src/game/game_handler.cpp
@@ -6062,7 +6062,64 @@ void GameHandler::handlePacket(network::Packet& packet) {
             packet.setReadPos(packet.getSize());
             break;
         }
-        case Opcode::SMSG_SPELLLOGEXECUTE:
+        case Opcode::SMSG_SPELLLOGEXECUTE: {
+            // WotLK: packed_guid caster + uint32 spellId + uint32 effectCount
+            // TBC/Classic: uint64 caster + uint32 spellId + uint32 effectCount
+            // Per-effect: uint8 effectType + uint32 effectLogCount + effect-specific data
+            // Effect 24 = SPELL_EFFECT_CREATE_ITEM: uint32 itemEntry per entry
+            const bool exeTbcLike = isClassicLikeExpansion() || isActiveExpansion("tbc");
+            if (packet.getSize() - packet.getReadPos() < (exeTbcLike ? 8u : 1u)) {
+                packet.setReadPos(packet.getSize()); break;
+            }
+            uint64_t exeCaster = exeTbcLike
+                ? packet.readUInt64() : UpdateObjectParser::readPackedGuid(packet);
+            if (packet.getSize() - packet.getReadPos() < 8) {
+                packet.setReadPos(packet.getSize()); break;
+            }
+            uint32_t exeSpellId = packet.readUInt32();
+            uint32_t exeEffectCount = packet.readUInt32();
+            exeEffectCount = std::min(exeEffectCount, 32u); // sanity
+
+            const bool isPlayerCaster = (exeCaster == playerGuid);
+            for (uint32_t ei = 0; ei < exeEffectCount; ++ei) {
+                if (packet.getSize() - packet.getReadPos() < 5) break;
+                uint8_t  effectType     = packet.readUInt8();
+                uint32_t effectLogCount = packet.readUInt32();
+                effectLogCount = std::min(effectLogCount, 64u); // sanity
+                if (effectType == 24) {
+                    // SPELL_EFFECT_CREATE_ITEM: uint32 itemEntry per log entry
+                    for (uint32_t li = 0; li < effectLogCount; ++li) {
+                        if (packet.getSize() - packet.getReadPos() < 4) break;
+                        uint32_t itemEntry = packet.readUInt32();
+                        if (isPlayerCaster && itemEntry != 0) {
+                            ensureItemInfo(itemEntry);
+                            const ItemQueryResponseData* info = getItemInfo(itemEntry);
+                            std::string itemName = info && !info->name.empty()
+                                ? info->name : ("item #" + std::to_string(itemEntry));
+                            loadSpellNameCache();
+                            auto spellIt = spellNameCache_.find(exeSpellId);
+                            std::string spellName = (spellIt != spellNameCache_.end() && !spellIt->second.name.empty())
+                                ? spellIt->second.name : "";
+                            std::string msg = spellName.empty()
+                                ? ("You create: " + itemName + ".")
+                                : ("You create " + itemName + " using " + spellName + ".");
+                            addSystemChatMessage(msg);
+                            LOG_DEBUG("SMSG_SPELLLOGEXECUTE CREATE_ITEM: spell=", exeSpellId,
+                                      " item=", itemEntry, " name=", itemName);
+                        }
+                    }
+                } else {
+                    // Other effect types: consume their data safely
+                    // Most effects have no trailing per-entry data beyond the count header,
+                    // or use variable-length sub-records we cannot safely skip.
+                    // Stop parsing at first unknown effect to avoid misalignment.
+                    packet.setReadPos(packet.getSize());
+                    break;
+                }
+            }
+            packet.setReadPos(packet.getSize());
+            break;
+        }
         case Opcode::SMSG_SPELL_CHANCE_RESIST_PUSHBACK:
         case Opcode::SMSG_SPELL_UPDATE_CHAIN_TARGETS:
             packet.setReadPos(packet.getSize());