mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-03-23 07:40:14 +00:00
Fix CodeQL weak-crypto suppressions: switch lgtm to codeql inline format
The old `// lgtm [cpp/...]` comments used a space (invalid syntax) and were placed on preceding lines rather than inline with the flagged code. GitHub's CodeQL action v3 requires `// codeql[query-id]` on the same line as the flagged expression. All four alert sites updated: - world_socket.cpp: encryptCipher/decryptCipher.init() (protocol RC4) - warden_module.cpp: decryptRC4() call (Warden protocol RC4) - warden_crypto.cpp: initRC4() calls (Warden stream cipher init) - game_handler.cpp: wardenLoadedModule_->load() (MD5+RC4 via Warden) All uses are protocol-mandated by Blizzard's WoW/Warden spec and cannot be replaced without breaking server interoperability.
This commit is contained in:
parent
28b4a3a599
commit
e304931435
4 changed files with 7 additions and 12 deletions
|
|
@ -443,12 +443,10 @@ void WorldSocket::initEncryption(const std::vector<uint8_t>& sessionKey, uint32_
|
|||
std::vector<uint8_t> encryptHash = auth::Crypto::hmacSHA1(encryptKey, sessionKey);
|
||||
std::vector<uint8_t> decryptHash = auth::Crypto::hmacSHA1(decryptKey, sessionKey);
|
||||
|
||||
// lgtm [cpp/weak-cryptographic-algorithm]
|
||||
// WoW WotLK world-header stream cipher is protocol-defined RC4.
|
||||
// Replacing it would break interoperability with target servers.
|
||||
encryptCipher.init(encryptHash);
|
||||
// lgtm [cpp/weak-cryptographic-algorithm]
|
||||
decryptCipher.init(decryptHash);
|
||||
encryptCipher.init(encryptHash); // codeql[cpp/weak-cryptographic-algorithm]
|
||||
decryptCipher.init(decryptHash); // codeql[cpp/weak-cryptographic-algorithm]
|
||||
|
||||
// Drop first 1024 bytes of keystream (WoW WotLK protocol requirement)
|
||||
encryptCipher.drop(1024);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue