From e42f8f1c03cb0339d0dee92d3354dc9957c6d66b Mon Sep 17 00:00:00 2001 From: Kelsi Date: Sun, 29 Mar 2026 21:35:49 -0700 Subject: [PATCH] fix: misleading indentation on reputation addon event dispatch The two fireAddonEvent calls were indented as if conditional on repChangeCallback_ but actually execute unconditionally (no braces). Fixed indentation and added clarifying comment. --- src/game/social_handler.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/game/social_handler.cpp b/src/game/social_handler.cpp index b1e36ac6..a4b64bf4 100644 --- a/src/game/social_handler.cpp +++ b/src/game/social_handler.cpp @@ -2479,8 +2479,9 @@ void SocialHandler::handleSetFactionStanding(network::Packet& packet) { owner_.addSystemChatMessage(buf); owner_.watchedFactionId_ = factionId; if (owner_.repChangeCallback_) owner_.repChangeCallback_(name, delta, standing); - owner_.fireAddonEvent("UPDATE_FACTION", {}); - owner_.fireAddonEvent("CHAT_MSG_COMBAT_FACTION_CHANGE", {std::string(buf)}); + // These events fire unconditionally on any rep change (not gated by callback). + owner_.fireAddonEvent("UPDATE_FACTION", {}); + owner_.fireAddonEvent("CHAT_MSG_COMBAT_FACTION_CHANGE", {std::string(buf)}); } } }