From e46919cc2c2f4f8f143d2be7912467283a0abda0 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Sun, 22 Mar 2026 18:22:56 -0700 Subject: [PATCH] fix: use rich tooltip display for SetAction items and SetHyperlink SetAction's item branch and SetHyperlink's item/spell branches showed only the item name, ignoring the full tooltip system we built. SetAction item path now uses _WoweePopulateItemTooltip (shows armor, stats, damage, bind type, sell price etc.). SetHyperlink item path now uses _WoweePopulateItemTooltip; spell path now uses SetSpellByID (shows cost, range, cast time, cooldown). This means shift-clicking an item link in chat, hovering an item on the action bar, or viewing any hyperlink tooltip now shows the full stat breakdown instead of just the name. --- src/addons/lua_engine.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/addons/lua_engine.cpp b/src/addons/lua_engine.cpp index 3ebae787..7d819253 100644 --- a/src/addons/lua_engine.cpp +++ b/src/addons/lua_engine.cpp @@ -5275,14 +5275,13 @@ void LuaEngine::registerCoreAPI() { " if not link then return end\n" " local id = link:match('item:(%d+)')\n" " if id then\n" - " local name, _, quality = GetItemInfo(tonumber(id))\n" - " if name then self:SetText(name, 1, 1, 1) end\n" + " _WoweePopulateItemTooltip(self, tonumber(id))\n" " return\n" " end\n" " id = link:match('spell:(%d+)')\n" " if id then\n" - " local name = GetSpellInfo(tonumber(id))\n" - " if name then self:SetText(name, 1, 1, 1) end\n" + " self:SetSpellByID(tonumber(id))\n" + " return\n" " end\n" "end\n" // Shared item tooltip builder using GetItemInfo return values @@ -5444,8 +5443,7 @@ void LuaEngine::registerCoreAPI() { " if actionType == 'spell' and id and id > 0 then\n" " self:SetSpellByID(id)\n" " elseif actionType == 'item' and id and id > 0 then\n" - " local name, _, quality = GetItemInfo(id)\n" - " if name then self:SetText(name, 1, 1, 1) end\n" + " _WoweePopulateItemTooltip(self, id)\n" " end\n" "end\n" "function GameTooltip:FadeOut() end\n"