phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-03 20:03:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

perf: entity/skill/DBC/warden maps to unordered_map; fix 3x contacts scan

Browse source 
Entity storage: std::map<uint64_t, shared_ptr<Entity>> → unordered_map for
O(1) entity lookups instead of O(log n). No code depends on GUID ordering.

Player skills: std::map<uint32_t, PlayerSkill> → unordered_map.
DBC ID cache: std::map<uint32_t, uint32_t> → unordered_map.
Warden: apiHandlers_ and allocations_ → unordered_map (freeBlocks_ kept
as std::map since its coalescing logic requires ordered iteration).

Contacts: handleFriendStatus() did 3 separate O(n) find_if scans per
packet. Consolidated to single find_if with iterator reuse. O(3n) → O(n).
This commit is contained in:
Kelsi 2026-03-27 18:28:36 -07:00
parent 2af3594ce8
commit e61b23626a
5 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
include/game/entity.hpp
View file

@ -3,6 +3,7 @@
#include <cstdint>
#include <string>
#include <map>
#include <unordered_map>
#include <memory>
namespace wowee {
@ -338,7 +339,7 @@ public:
bool hasEntity(uint64_t guid) const;
// Get all entities
const std::map<uint64_t, std::shared_ptr<Entity>>& getEntities() const {
const std::unordered_map<uint64_t, std::shared_ptr<Entity>>& getEntities() const {
return entities;
}
@ -353,7 +354,7 @@ public:
}
private:
std::map<uint64_t, std::shared_ptr<Entity>> entities;
std::unordered_map<uint64_t, std::shared_ptr<Entity>> entities;
};
} // namespace game

4
include/game/game_handler.hpp
View file

@ -1106,7 +1106,7 @@ public:
uint32_t getOverrideLightTransMs() const { return overrideLightTransMs_; }
// Player skills
const std::map<uint32_t, PlayerSkill>& getPlayerSkills() const { return playerSkills_; }
const std::unordered_map<uint32_t, PlayerSkill>& getPlayerSkills() const { return playerSkills_; }
const std::string& getSkillName(uint32_t skillId) const;
uint32_t getSkillCategory(uint32_t skillId) const;
bool isProfessionSpell(uint32_t spellId) const;
@ -3502,7 +3502,7 @@ private:
uint32_t overrideLightTransMs_ = 0;
// ---- Player skills ----
std::map<uint32_t, PlayerSkill> playerSkills_;
std::unordered_map<uint32_t, PlayerSkill> playerSkills_;
std::unordered_map<uint32_t, std::string> skillLineNames_;
std::unordered_map<uint32_t, uint32_t> skillLineCategories_;
std::unordered_map<uint32_t, uint32_t> spellToSkillLine_; // spellID -> skillLineID

4
include/game/warden_emulator.hpp
View file

@ -156,12 +156,12 @@ private:
int argCount;
std::function<uint32_t(WardenEmulator&, const std::vector<uint32_t>&)> handler;
};
std::map<uint32_t, ApiHookEntry> apiHandlers_;
std::unordered_map<uint32_t, ApiHookEntry> apiHandlers_;
uint32_t nextApiStubAddr_; // tracks next free stub slot (replaces static local)
bool apiCodeHookRegistered_; // true once UC_HOOK_CODE for stub range is added
// Memory allocation tracking
std::map<uint32_t, size_t> allocations_;
std::unordered_map<uint32_t, size_t> allocations_;
std::map<uint32_t, size_t> freeBlocks_; // free-list keyed by base address
uint32_t nextHeapAddr_;