phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 17:43:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf: entity/skill/DBC/warden maps to unordered_map; fix 3x contacts scan

Browse source 
Entity storage: std::map<uint64_t, shared_ptr<Entity>> → unordered_map for
O(1) entity lookups instead of O(log n). No code depends on GUID ordering.

Player skills: std::map<uint32_t, PlayerSkill> → unordered_map.
DBC ID cache: std::map<uint32_t, uint32_t> → unordered_map.
Warden: apiHandlers_ and allocations_ → unordered_map (freeBlocks_ kept
as std::map since its coalescing logic requires ordered iteration).

Contacts: handleFriendStatus() did 3 separate O(n) find_if scans per
packet. Consolidated to single find_if with iterator reuse. O(3n) → O(n).
This commit is contained in:
Kelsi 2026-03-27 18:28:36 -07:00
parent 2af3594ce8
commit e61b23626a
5 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/game/game_handler.cpp
View file

@ -23802,16 +23802,16 @@ void GameHandler::handleFriendStatus(network::Packet& packet) {
return;
}
// Single lookup — reuse iterator for name resolution and update/erase below
auto cit = std::find_if(contacts_.begin(), contacts_.end(),
[&](const ContactEntry& e){ return e.guid == data.guid; });
// Look up player name: contacts_ (populated by SMSG_FRIEND_LIST) > playerNameCache
std::string playerName;
{
auto cit2 = std::find_if(contacts_.begin(), contacts_.end(),
[&](const ContactEntry& e){ return e.guid == data.guid; });
if (cit2 != contacts_.end() && !cit2->name.empty()) {
playerName = cit2->name;
} else {
playerName = lookupName(data.guid);
}
if (cit != contacts_.end() && !cit->name.empty()) {
playerName = cit->name;
} else {
playerName = lookupName(data.guid);
}
// Update friends cache
@ -23823,11 +23823,9 @@ void GameHandler::handleFriendStatus(network::Packet& packet) {
// Mirror into contacts_: update existing entry or add/remove as needed
if (data.status == 0) { // Removed from friends list
contacts_.erase(std::remove_if(contacts_.begin(), contacts_.end(),
[&](const ContactEntry& e){ return e.guid == data.guid; }), contacts_.end());
if (cit != contacts_.end())
contacts_.erase(cit);
} else {
auto cit = std::find_if(contacts_.begin(), contacts_.end(),
[&](const ContactEntry& e){ return e.guid == data.guid; });
if (cit != contacts_.end()) {
if (!playerName.empty() && playerName != "Unknown") cit->name = playerName;
// status: 2=online→1, 3=offline→0, 1=added→1 (online on add)
@ -24028,7 +24026,7 @@ void GameHandler::extractSkillFields(const std::map<uint16_t, uint32_t>& fields)
const uint16_t PLAYER_SKILL_INFO_START = fieldIndex(UF::PLAYER_SKILL_INFO_START);
static constexpr int MAX_SKILL_SLOTS = 128;
std::map<uint32_t, PlayerSkill> newSkills;
std::unordered_map<uint32_t, PlayerSkill> newSkills;
for (int slot = 0; slot < MAX_SKILL_SLOTS; slot++) {
uint16_t baseField = PLAYER_SKILL_INFO_START + slot * 3;