phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-07 05:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: async creature upload budget blocked cache hits and failures

Browse source 
The per-tick GPU upload budget check ran before consuming async futures,
so after 1 upload ALL remaining ready results were deferred — including
permanent failures and cache hits that need zero GPU work. Moved the
budget gate after failure/cache-hit processing so only actual uploads
count. Re-queues over-budget results as pending spawns for next frame.
This commit is contained in:
Kelsi 2026-03-29 19:16:27 -07:00
parent 05cfcaacf6
commit e72cb4d380
1 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/core/application.cpp
View file

@ -8472,16 +8472,14 @@ void Application::processAsyncCreatureResults(bool unlimited) {
continue;
}
// Peek: if this result needs a NEW model upload (not cached) and we've hit
// the upload budget, defer to next frame without consuming the future.
if (modelUploads >= maxUploadsThisTick) {
break;
}
auto result = it->future.get();
it = asyncCreatureLoads_.erase(it);
asyncCreatureDisplayLoads_.erase(result.displayId);
// Failures and cache hits need no GPU work — process them even when the
// upload budget is exhausted. Previously the budget check was above this
// point, blocking ALL ready futures (including zero-cost ones) after a
// single upload, which throttled creature spawn throughput during world load.
if (result.permanent_failure) {
nonRenderableCreatureDisplayIds_.insert(result.displayId);
creaturePermanentFailureGuids_.insert(result.guid);
@ -8516,6 +8514,23 @@ void Application::processAsyncCreatureResults(bool unlimited) {
continue;
}
// Only actual GPU uploads count toward the per-tick budget.
if (modelUploads >= maxUploadsThisTick) {
// Re-queue this result — it needs a GPU upload but we're at budget.
// Push a new pending spawn so it's retried next frame.
pendingCreatureSpawnGuids_.erase(result.guid);
creatureSpawnRetryCounts_.erase(result.guid);
PendingCreatureSpawn s{};
s.guid = result.guid;
s.displayId = result.displayId;
s.x = result.x; s.y = result.y; s.z = result.z;
s.orientation = result.orientation;
s.scale = result.scale;
pendingCreatureSpawns_.push_back(s);
pendingCreatureSpawnGuids_.insert(result.guid);
continue;
}
// Model parsed on background thread — upload to GPU on main thread.
auto* charRenderer = renderer ? renderer->getCharacterRenderer() : nullptr;
if (!charRenderer) {