phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-04 16:23:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: add [[nodiscard]] to shader/asset load functions, suppress warnings

Browse source 
Add [[nodiscard]] to VkShaderModule::loadFromFile, Shader::loadFromFile/
loadFromSource, AssetManifest::load, DbcLoader::load — all return bool
indicating success/failure that callers should check.

Suppress with (void) at 17 call sites where validity is checked via
isValid() after loading rather than the return value (m2_renderer
recreatePipelines, swim_effects recreatePipelines).
This commit is contained in:
Kelsi 2026-03-27 15:17:19 -07:00
parent b5b84fbc19
commit e805eae33c
6 changed files with 27 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/pipeline/asset_manifest.hpp
View file

@ -29,7 +29,7 @@ public:
* @param manifestPath Full path to manifest.json
* @return true if loaded successfully
*/
bool load(const std::string& manifestPath);
[[nodiscard]] bool load(const std::string& manifestPath);
/**
* Lookup an entry by normalized WoW path (lowercase, backslash)

2
include/pipeline/dbc_loader.hpp
View file

@ -26,7 +26,7 @@ public:
* @param dbcData Raw DBC file data
* @return true if loaded successfully
*/
bool load(const std::vector<uint8_t>& dbcData);
[[nodiscard]] bool load(const std::vector<uint8_t>& dbcData);
/**
* Check if DBC is loaded

4
include/rendering/shader.hpp
View file

@ -13,8 +13,8 @@ public:
Shader() = default;
~Shader();
bool loadFromFile(const std::string& vertexPath, const std::string& fragmentPath);
bool loadFromSource(const std::string& vertexSource, const std::string& fragmentSource);
[[nodiscard]] bool loadFromFile(const std::string& vertexPath, const std::string& fragmentPath);
[[nodiscard]] bool loadFromSource(const std::string& vertexSource, const std::string& fragmentSource);
void use() const;
void unuse() const;

2
include/rendering/vk_shader.hpp
View file

@ -18,7 +18,7 @@ public:
VkShaderModule& operator=(VkShaderModule&& other) noexcept;
// Load a SPIR-V file from disk
bool loadFromFile(VkDevice device, const std::string& path);
[[nodiscard]] bool loadFromFile(VkDevice device, const std::string& path);
// Load from raw SPIR-V bytes
bool loadFromMemory(VkDevice device, const uint32_t* code, size_t sizeBytes);