mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-03-24 16:10:14 +00:00
Fix real bugs found by clang-tidy
- game_handler.cpp: use-after-move on node.id after std::move(node) (save nodeId before the move) - tcp_socket.cpp, world_socket.cpp: virtual call in destructor bypasses dispatch; use qualified TCPSocket::disconnect() / WorldSocket::disconnect() to make intent explicit - wmo_renderer.cpp: float loop counters risk precision drift; replace with integer step counts and reconstruct float from index - game_screen.cpp: (float + 0.5) cast to int is incorrect rounding; use std::lround instead
This commit is contained in:
parent
ba3d569e5f
commit
eacecddfb0
5 changed files with 13 additions and 8 deletions
|
|
@ -9513,10 +9513,11 @@ void GameHandler::loadTaxiDbc() {
|
|||
node.mountDisplayIdHorde = nodesDbc->getUInt32(i, mountHordeFB);
|
||||
}
|
||||
}
|
||||
if (node.id > 0) {
|
||||
taxiNodes_[node.id] = std::move(node);
|
||||
uint32_t nodeId = node.id;
|
||||
if (nodeId > 0) {
|
||||
taxiNodes_[nodeId] = std::move(node);
|
||||
}
|
||||
if (node.id == 195) {
|
||||
if (nodeId == 195) {
|
||||
std::string fields;
|
||||
for (uint32_t f = 0; f < fieldCount; f++) {
|
||||
fields += std::to_string(f) + ":" + std::to_string(nodesDbc->getUInt32(i, f)) + " ";
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue