mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-03-23 15:50:20 +00:00
Fix real bugs found by clang-tidy
- game_handler.cpp: use-after-move on node.id after std::move(node) (save nodeId before the move) - tcp_socket.cpp, world_socket.cpp: virtual call in destructor bypasses dispatch; use qualified TCPSocket::disconnect() / WorldSocket::disconnect() to make intent explicit - wmo_renderer.cpp: float loop counters risk precision drift; replace with integer step counts and reconstruct float from index - game_screen.cpp: (float + 0.5) cast to int is incorrect rounding; use std::lround instead
This commit is contained in:
parent
ba3d569e5f
commit
eacecddfb0
5 changed files with 13 additions and 8 deletions
|
|
@ -11,7 +11,7 @@ TCPSocket::TCPSocket() {
|
|||
}
|
||||
|
||||
TCPSocket::~TCPSocket() {
|
||||
disconnect();
|
||||
TCPSocket::disconnect(); // qualified call: virtual dispatch is bypassed in destructors
|
||||
}
|
||||
|
||||
bool TCPSocket::connect(const std::string& host, uint16_t port) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue