Fix real bugs found by clang-tidy

- game_handler.cpp: use-after-move on node.id after std::move(node)
  (save nodeId before the move)
- tcp_socket.cpp, world_socket.cpp: virtual call in destructor bypasses
  dispatch; use qualified TCPSocket::disconnect() / WorldSocket::disconnect()
  to make intent explicit
- wmo_renderer.cpp: float loop counters risk precision drift; replace with
  integer step counts and reconstruct float from index
- game_screen.cpp: (float + 0.5) cast to int is incorrect rounding;
  use std::lround instead
This commit is contained in:
Kelsi 2026-02-18 20:02:12 -08:00
parent ba3d569e5f
commit eacecddfb0
5 changed files with 13 additions and 8 deletions

View file

@ -60,7 +60,7 @@ WorldSocket::WorldSocket() {
}
WorldSocket::~WorldSocket() {
disconnect();
WorldSocket::disconnect(); // qualified call: virtual dispatch is bypassed in destructors
}
bool WorldSocket::connect(const std::string& host, uint16_t port) {