phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: handle MSG_MOVE_SET_*_SPEED opcodes to suppress unhandled opcode warnings

Browse source
This commit is contained in:
Kelsi 2026-03-13 03:13:29 -07:00
parent 64439673ce
commit ebd9cf5542
2 changed files with 51 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/game/game_handler.hpp
View file

@ -2199,6 +2199,7 @@ private:
// ---- Other player movement (MSG_MOVE_* from server) ----
void handleOtherPlayerMovement(network::Packet& packet);
void handleMoveSetSpeed(network::Packet& packet);
// ---- Phase 5 handlers ----
void handleLootResponse(network::Packet& packet);

50
src/game/game_handler.cpp
View file

@ -5338,6 +5338,22 @@ void GameHandler::handlePacket(network::Packet& packet) {
}
break;
// ---- Broadcast speed changes (server→client, no ACK) ----
// Format: PackedGuid (mover) + MovementInfo (variable) + float speed
// MovementInfo is complex (optional transport/fall/spline blocks based on flags).
// We consume the packet to suppress "Unhandled world opcode" warnings.
case Opcode::MSG_MOVE_SET_RUN_SPEED:
case Opcode::MSG_MOVE_SET_RUN_BACK_SPEED:
case Opcode::MSG_MOVE_SET_WALK_SPEED:
case Opcode::MSG_MOVE_SET_SWIM_SPEED:
case Opcode::MSG_MOVE_SET_SWIM_BACK_SPEED:
case Opcode::MSG_MOVE_SET_FLIGHT_SPEED:
case Opcode::MSG_MOVE_SET_FLIGHT_BACK_SPEED:
if (state == WorldState::IN_WORLD) {
handleMoveSetSpeed(packet);
}
break;
// ---- Mail ----
case Opcode::SMSG_SHOW_MAILBOX:
handleShowMailbox(packet);
@ -15108,6 +15124,40 @@ void GameHandler::handlePvpLogData(network::Packet& packet) {
}
}
void GameHandler::handleMoveSetSpeed(network::Packet& packet) {
// MSG_MOVE_SET_*_SPEED: PackedGuid (WotLK) / full uint64 (Classic/TBC) + MovementInfo + float speed.
// The MovementInfo block is variable-length; rather than fully parsing it, we read the
// fixed prefix, skip over optional blocks by consuming remaining bytes until 4 remain,
// then read the speed float. This is safe because the speed is always the last field.
const bool useFull = isClassicLikeExpansion() || isActiveExpansion("tbc");
uint64_t moverGuid = useFull
? packet.readUInt64() : UpdateObjectParser::readPackedGuid(packet);
// Skip to the last 4 bytes — the speed float — by advancing past the MovementInfo.
// This avoids duplicating the full variable-length MovementInfo parser here.
const size_t remaining = packet.getSize() - packet.getReadPos();
if (remaining < 4) return;
if (remaining > 4) {
// Advance past all MovementInfo bytes (flags, time, position, optional blocks).
// Speed is always the last 4 bytes in the packet.
packet.setReadPos(packet.getSize() - 4);
}
float speed = packet.readFloat();
if (!std::isfinite(speed) || speed <= 0.01f || speed > 200.0f) return;
// Update local player speed state if this broadcast targets us.
if (moverGuid != playerGuid) return;
const uint16_t wireOp = packet.getOpcode();
if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_RUN_SPEED)) serverRunSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_RUN_BACK_SPEED)) serverRunBackSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_WALK_SPEED)) serverWalkSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_SWIM_SPEED)) serverSwimSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_SWIM_BACK_SPEED)) serverSwimBackSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_FLIGHT_SPEED)) serverFlightSpeed_ = speed;
else if (wireOp == wireOpcode(Opcode::MSG_MOVE_SET_FLIGHT_BACK_SPEED))serverFlightBackSpeed_= speed;
}
void GameHandler::handleOtherPlayerMovement(network::Packet& packet) {
// Server relays MSG_MOVE_* for other players: packed GUID (WotLK) or full uint64 (TBC/Classic)
const bool otherMoveTbc = isClassicLikeExpansion() || isActiveExpansion("tbc");