phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-23 15:50:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 41

tbc: implement SMSG_INIT/SET_EXTRA_AURA_INFO_OBSOLETE for buff tracking

Browse source 
TBC 2.4.3 does not have SMSG_AURA_UPDATE (added in WotLK). Instead it
uses SMSG_INIT_EXTRA_AURA_INFO_OBSOLETE (0x3A3) for full aura refresh
on login/zone and SMSG_SET_EXTRA_AURA_INFO_OBSOLETE (0x3A4) for single-
slot updates. Implement handlers for both packets so TBC buff/debuff bars
populate correctly.

Also implement SMSG_CLEAR_EXTRA_AURA_INFO (0x3A6) to remove individual
aura slots when buffs expire or are cancelled server-side.

Format parsed: uint64 targetGuid + uint8 count + per-slot {uint8 slot,
uint32 spellId, uint8 effectIndex, uint8 flags, uint32 durationMs,
uint32 maxDurationMs}. Infinite auras (0xFFFFFFFF) stored as durationMs=-1.
This commit is contained in:
Kelsi 2026-03-09 22:20:47 -07:00
parent edd7e5e591
commit ede380ec60
1 changed files with 56 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

59
src/game/game_handler.cpp
View file

@ -4420,10 +4420,47 @@ void GameHandler::handlePacket(network::Packet& packet) {
break;
}
case Opcode::SMSG_INIT_EXTRA_AURA_INFO_OBSOLETE:
case Opcode::SMSG_SET_EXTRA_AURA_INFO_OBSOLETE:
// Extra aura metadata (icons/durations) not yet consumed by aura UI.
case Opcode::SMSG_SET_EXTRA_AURA_INFO_OBSOLETE: {
// TBC 2.4.3 aura tracking: replaces SMSG_AURA_UPDATE which doesn't exist in TBC.
// Format: uint64 targetGuid + uint8 count + N×{uint8 slot, uint32 spellId,
// uint8 effectIndex, uint8 flags, uint32 durationMs, uint32 maxDurationMs}
const bool isInit = (*logicalOp == Opcode::SMSG_INIT_EXTRA_AURA_INFO_OBSOLETE);
auto remaining = [&]() { return packet.getSize() - packet.getReadPos(); };
if (remaining() < 9) { packet.setReadPos(packet.getSize()); break; }
uint64_t auraTargetGuid = packet.readUInt64();
uint8_t count = packet.readUInt8();
std::vector<AuraSlot>* auraList = nullptr;
if (auraTargetGuid == playerGuid) auraList = &playerAuras;
else if (auraTargetGuid == targetGuid) auraList = &targetAuras;
if (auraList && isInit) auraList->clear();
uint64_t nowMs = static_cast<uint64_t>(
std::chrono::duration_cast<std::chrono::milliseconds>(
std::chrono::steady_clock::now().time_since_epoch()).count());
for (uint8_t i = 0; i < count && remaining() >= 13; i++) {
uint8_t slot = packet.readUInt8();
uint32_t spellId = packet.readUInt32();
(void) packet.readUInt8(); // effectIndex (unused for slot display)
uint8_t flags = packet.readUInt8();
uint32_t durationMs = packet.readUInt32();
uint32_t maxDurMs = packet.readUInt32();
if (auraList) {
while (auraList->size() <= slot) auraList->push_back(AuraSlot{});
AuraSlot& a = (*auraList)[slot];
a.spellId = spellId;
a.flags = flags;
a.durationMs = (durationMs == 0xFFFFFFFF) ? -1 : static_cast<int32_t>(durationMs);
a.maxDurationMs= (maxDurMs == 0xFFFFFFFF) ? -1 : static_cast<int32_t>(maxDurMs);
a.receivedAtMs = nowMs;
}
}
packet.setReadPos(packet.getSize());
break;
}
case Opcode::MSG_MOVE_WORLDPORT_ACK:
// Client uses this outbound; treat inbound variant as no-op for robustness.
packet.setReadPos(packet.getSize());
@ -4729,8 +4766,24 @@ void GameHandler::handlePacket(network::Packet& packet) {
packet.setReadPos(packet.getSize());
break;
case Opcode::SMSG_CLEAR_EXTRA_AURA_INFO: {
// TBC 2.4.3: clear a single aura slot for a unit
// Format: uint64 targetGuid + uint8 slot
if (packet.getSize() - packet.getReadPos() >= 9) {
uint64_t clearGuid = packet.readUInt64();
uint8_t slot = packet.readUInt8();
std::vector<AuraSlot>* auraList = nullptr;
if (clearGuid == playerGuid) auraList = &playerAuras;
else if (clearGuid == targetGuid) auraList = &targetAuras;
if (auraList && slot < auraList->size()) {
(*auraList)[slot] = AuraSlot{};
}
}
packet.setReadPos(packet.getSize());
break;
}
// ---- Misc consume ----
case Opcode::SMSG_CLEAR_EXTRA_AURA_INFO:
case Opcode::SMSG_COMPLAIN_RESULT:
case Opcode::SMSG_ITEM_REFUND_INFO_RESPONSE:
case Opcode::SMSG_ITEM_ENCHANT_TIME_UPDATE: