phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-06 05:03:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor: extract toHexString utility, more color constants, final cast cleanup

Browse source 
Add core::toHexString() utility in logger.hpp to replace 11 duplicate
hex-dump loops across world_packets, world_socket, and game_handler.
Add kColorBrightGreen/kColorDarkGray constants in game_screen.cpp
replacing 26 inline literals. Replace remaining ~37 C-style casts in
16 files. Normalize keybinding_manager.hpp to #pragma once.
This commit is contained in:
Kelsi 2026-03-25 12:12:03 -07:00
parent ba99d505dd
commit eea205ffc9
5 changed files with 63 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/network/world_socket.cpp
View file

@ -360,13 +360,8 @@ void WorldSocket::send(const Packet& packet) {
}
if (kLogSwapItemPackets && (opcode == 0x10C || opcode == 0x10D)) { // CMSG_SWAP_ITEM / CMSG_SWAP_INV_ITEM
std::string hex;
for (size_t i = 0; i < data.size(); i++) {
char buf[4];
snprintf(buf, sizeof(buf), "%02x ", data[i]);
hex += buf;
}
LOG_INFO("WS TX opcode=0x", std::hex, opcode, std::dec, " payloadLen=", payloadLen, " data=[", hex, "]");
LOG_INFO("WS TX opcode=0x", std::hex, opcode, std::dec, " payloadLen=", payloadLen,
" data=[", core::toHexString(data.data(), data.size(), true), "]");
}
const auto traceNow = std::chrono::steady_clock::now();
@ -418,14 +413,8 @@ void WorldSocket::send(const Packet& packet) {
// Debug: dump packet bytes for AUTH_SESSION
if (opcode == 0x1ED) {
std::string hexDump = "AUTH_SESSION raw bytes: ";
for (size_t i = 0; i < sendData.size(); ++i) {
char buf[4];
snprintf(buf, sizeof(buf), "%02x ", sendData[i]);
hexDump += buf;
if ((i + 1) % 32 == 0) hexDump += "\n";
}
LOG_DEBUG(hexDump);
LOG_DEBUG("AUTH_SESSION raw bytes: ",
core::toHexString(sendData.data(), sendData.size(), true));
}
if (isLoginPipelineCmsg(opcode)) {
LOG_INFO("WS TX LOGIN opcode=0x", std::hex, opcode, std::dec,
@ -588,11 +577,9 @@ void WorldSocket::pumpNetworkIO() {
}
// Hex dump received bytes for auth debugging (debug-only to avoid per-frame string work)
if (debugLog && bytesReadThisTick <= 128) {
std::string hex;
for (size_t i = receiveReadOffset_; i < receiveBuffer.size(); ++i) {
char buf[4]; snprintf(buf, sizeof(buf), "%02x ", receiveBuffer[i]); hex += buf;
}
LOG_DEBUG("World socket raw bytes: ", hex);
LOG_DEBUG("World socket raw bytes: ",
core::toHexString(receiveBuffer.data() + receiveReadOffset_,
receiveBuffer.size() - receiveReadOffset_, true));
}
tryParsePackets();
if (debugLog && connected && bufferedBytes() > 0) {