phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-03 20:03:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

perf: switch 3 spawn queues from vector to deque

Browse source 
pendingPlayerSpawns_, deferredEquipmentQueue_, and
pendingGameObjectSpawns_ are consumed from the front via erase(begin()),
which is O(n) on vector (shifts all elements). With many spawns queued
(entering a city), this made the processing loop O(n²). deque supports
O(1) front erasure. pendingCreatureSpawns_ already used deque.
This commit is contained in:
Kelsi 2026-03-29 19:51:26 -07:00
parent 3b7ac068d2
commit f2237c5531
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
include/core/application.hpp
View file

@ -344,7 +344,8 @@ private:
std::unordered_map<uint64_t, OnlinePlayerAppearanceState> onlinePlayerAppearance_; std::unordered_map<uint64_t, OnlinePlayerAppearanceState> onlinePlayerAppearance_;
std::unordered_map<uint64_t, std::pair<std::array<uint32_t, 19>, std::array<uint8_t, 19>>> pendingOnlinePlayerEquipment_; std::unordered_map<uint64_t, std::pair<std::array<uint32_t, 19>, std::array<uint8_t, 19>>> pendingOnlinePlayerEquipment_;
// Deferred equipment compositing queue — processes max 1 per frame to avoid stutter // Deferred equipment compositing queue — processes max 1 per frame to avoid stutter
std::vector<std::pair<uint64_t, std::pair<std::array<uint32_t, 19>, std::array<uint8_t, 19>>>> deferredEquipmentQueue_; // deque: consumed from front in a loop; vector::erase(begin) would be O(n²).
std::deque<std::pair<uint64_t, std::pair<std::array<uint32_t, 19>, std::array<uint8_t, 19>>>> deferredEquipmentQueue_;
void processDeferredEquipmentQueue(); void processDeferredEquipmentQueue();
// Async equipment texture pre-decode: BLP decode on background thread, composite on main thread // Async equipment texture pre-decode: BLP decode on background thread, composite on main thread
struct PreparedEquipmentUpdate { struct PreparedEquipmentUpdate {
@ -402,7 +403,7 @@ private:
uint8_t facialFeatures; uint8_t facialFeatures;
float x, y, z, orientation; float x, y, z, orientation;
}; };
std::vector<PendingPlayerSpawn> pendingPlayerSpawns_; std::deque<PendingPlayerSpawn> pendingPlayerSpawns_;
std::unordered_set<uint64_t> pendingPlayerSpawnGuids_; std::unordered_set<uint64_t> pendingPlayerSpawnGuids_;
void processPlayerSpawnQueue(); void processPlayerSpawnQueue();
std::unordered_set<uint64_t> creaturePermanentFailureGuids_; std::unordered_set<uint64_t> creaturePermanentFailureGuids_;
@ -415,7 +416,7 @@ private:
float x, y, z, orientation; float x, y, z, orientation;
float scale = 1.0f; float scale = 1.0f;
}; };
std::vector<PendingGameObjectSpawn> pendingGameObjectSpawns_; std::deque<PendingGameObjectSpawn> pendingGameObjectSpawns_;
void processGameObjectSpawnQueue(); void processGameObjectSpawnQueue();
// Async WMO loading for game objects (file I/O + parse on background thread) // Async WMO loading for game objects (file I/O + parse on background thread)