From f53337305021c8a484b9510d1c715c711b2575c8 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Tue, 10 Mar 2026 04:25:45 -0700 Subject: [PATCH] game: downgrade combat/charEnum per-entry LOG_INFO to LOG_DEBUG in WotLK parsers Consistent with the same cleanup for Classic/TBC parsers. Melee hit, spell damage, and spell heal logs fire on every combat event and belong at DEBUG level. Per-character detail lines in the WotLK CharEnum parser are also consolidated to a single DEBUG line per character. --- src/game/world_packets.cpp | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/src/game/world_packets.cpp b/src/game/world_packets.cpp index 4ecc1555..11049d5d 100644 --- a/src/game/world_packets.cpp +++ b/src/game/world_packets.cpp @@ -480,21 +480,9 @@ bool CharEnumParser::parse(network::Packet& packet, CharEnumResponse& response) character.equipment.push_back(item); } - LOG_INFO(" Character ", (int)(i + 1), ": ", character.name); - LOG_INFO(" GUID: 0x", std::hex, character.guid, std::dec); - LOG_INFO(" ", getRaceName(character.race), " ", - getClassName(character.characterClass), " (", - getGenderName(character.gender), ")"); - LOG_INFO(" Level: ", (int)character.level); - LOG_INFO(" Location: Zone ", character.zoneId, ", Map ", character.mapId); - LOG_INFO(" Position: (", character.x, ", ", character.y, ", ", character.z, ")"); - if (character.hasGuild()) { - LOG_INFO(" Guild ID: ", character.guildId); - } - if (character.hasPet()) { - LOG_INFO(" Pet: Model ", character.pet.displayModel, - ", Level ", character.pet.level); - } + LOG_DEBUG(" Character ", (int)(i + 1), ": ", character.name, + " (", getRaceName(character.race), " ", getClassName(character.characterClass), + " level ", (int)character.level, " zone ", character.zoneId, ")"); response.characters.push_back(character); } @@ -2771,9 +2759,9 @@ bool AttackerStateUpdateParser::parse(network::Packet& packet, AttackerStateUpda data.blocked = packet.readUInt32(); } - LOG_INFO("Melee hit: ", data.totalDamage, " damage", - data.isCrit() ? " (CRIT)" : "", - data.isMiss() ? " (MISS)" : ""); + LOG_DEBUG("Melee hit: ", data.totalDamage, " damage", + data.isCrit() ? " (CRIT)" : "", + data.isMiss() ? " (MISS)" : ""); return true; } @@ -2797,8 +2785,8 @@ bool SpellDamageLogParser::parse(network::Packet& packet, SpellDamageLogData& da // Check crit flag data.isCrit = (flags & 0x02) != 0; - LOG_INFO("Spell damage: spellId=", data.spellId, " dmg=", data.damage, - data.isCrit ? " CRIT" : ""); + LOG_DEBUG("Spell damage: spellId=", data.spellId, " dmg=", data.damage, + data.isCrit ? " CRIT" : ""); return true; } @@ -2812,8 +2800,8 @@ bool SpellHealLogParser::parse(network::Packet& packet, SpellHealLogData& data) uint8_t critFlag = packet.readUInt8(); data.isCrit = (critFlag != 0); - LOG_INFO("Spell heal: spellId=", data.spellId, " heal=", data.heal, - data.isCrit ? " CRIT" : ""); + LOG_DEBUG("Spell heal: spellId=", data.spellId, " heal=", data.heal, + data.isCrit ? " CRIT" : ""); return true; }