From f930ecbffd5111e9c794d0bb5c236e6f547a235f Mon Sep 17 00:00:00 2001 From: Kelsi Date: Sat, 14 Mar 2026 14:51:27 -0700 Subject: [PATCH] fix(combatlog): reject truncated instakill logs without spell id --- src/game/game_handler.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp index f629002c..4780c372 100644 --- a/src/game/game_handler.cpp +++ b/src/game/game_handler.cpp @@ -6527,7 +6527,10 @@ void GameHandler::handlePacket(network::Packet& packet) { } uint64_t ikVictim = ikUsesFullGuid ? packet.readUInt64() : UpdateObjectParser::readPackedGuid(packet); - uint32_t ikSpell = (ik_rem() >= 4) ? packet.readUInt32() : 0; + if (ik_rem() < 4) { + packet.setReadPos(packet.getSize()); break; + } + uint32_t ikSpell = packet.readUInt32(); // Show kill/death feedback for the local player if (ikCaster == playerGuid) { addCombatText(CombatTextEntry::INSTAKILL, 0, ikSpell, true, 0, ikCaster, ikVictim);