phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-27 01:00:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Vanilla/Turtle WoW compatibility: fix UPDATE_OBJECT, chat, equipment, creatures

Browse source 
- Route SMSG_UPDATE_OBJECT through polymorphic parsers for correct
  vanilla format (uint8 updateFlags, 6 speeds vs WotLK uint16/9)
- Fix SMSG_DESTROY_OBJECT for vanilla (8 bytes, no isDeath field)
- Add MSG_MOVE_* handlers for other player movement relay
- Add ClassicPacketParsers::parseMessageChat with targetGuid read
  and monster-type name handling
- Resolve chat sender names from player name cache before display
- Fix CSV DBC field 0 always treated as numeric ID (fixes 16+ garbled
  Turtle CSVs including Map, AreaTable, Spell, CreatureDisplayInfo)
- Add CSV DBC validation: reject garbled CSVs (>80% zero IDs) and
  fall back to binary DBC files
- Fix ItemDisplayInfo texture component field index (14+ not 15+)
  for binary DBC with gender-aware suffix resolution
- Spawn other players as visible M2 models via creature callback
- Map name cache dedup prevents overwrites from duplicate CSV records
This commit is contained in:
Kelsi 2026-02-13 18:59:09 -08:00
parent 430c2bdcfa
commit fb0ae26fe6
13 changed files with 689 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

55
src/pipeline/asset_manager.cpp
View file

@ -264,6 +264,7 @@ std::shared_ptr<DBCFile> AssetManager::loadDBC(const std::string& name) {
std::vector<uint8_t> dbcData;
// Try expansion-specific CSV first (e.g. Data/expansions/wotlk/db/Spell.csv)
bool loadedFromCSV = false;
if (!expansionDataPath_.empty()) {
// Derive CSV name from DBC name: "Spell.dbc" -> "Spell.csv"
std::string baseName = name;
@ -281,6 +282,7 @@ std::shared_ptr<DBCFile> AssetManager::loadDBC(const std::string& name) {
dbcData.resize(static_cast<size_t>(size));
f.read(reinterpret_cast<char*>(dbcData.data()), size);
LOG_DEBUG("Found CSV DBC: ", csvPath);
loadedFromCSV = true;
}
}
}
@ -298,8 +300,57 @@ std::shared_ptr<DBCFile> AssetManager::loadDBC(const std::string& name) {
auto dbc = std::make_shared<DBCFile>();
if (!dbc->load(dbcData)) {
LOG_ERROR("Failed to load DBC: ", name);
return nullptr;
// If CSV failed to parse, try binary DBC fallback
if (loadedFromCSV) {
LOG_WARNING("CSV DBC failed to parse: ", name, " — trying binary DBC fallback");
dbcData.clear();
std::string dbcPath = "DBFilesClient\\" + name;
dbcData = readFile(dbcPath);
if (!dbcData.empty()) {
dbc = std::make_shared<DBCFile>();
if (dbc->load(dbcData)) {
loadedFromCSV = false;
LOG_INFO("Binary DBC fallback succeeded: ", name);
} else {
LOG_ERROR("Failed to load DBC: ", name);
return nullptr;
}
} else {
LOG_ERROR("Failed to load DBC: ", name);
return nullptr;
}
} else {
LOG_ERROR("Failed to load DBC: ", name);
return nullptr;
}
}
// Validate CSV-loaded DBCs: if >50 records but all have ID 0 in field 0,
// the CSV data is garbled (e.g. string data in the ID column).
if (loadedFromCSV && dbc->getRecordCount() > 50) {
uint32_t zeroIds = 0;
const uint32_t sampleSize = std::min(dbc->getRecordCount(), 100u);
for (uint32_t i = 0; i < sampleSize; ++i) {
if (dbc->getUInt32(i, 0) == 0) ++zeroIds;
}
// If >80% of sampled records have ID 0, the CSV is garbled
if (zeroIds > sampleSize * 4 / 5) {
LOG_WARNING("CSV DBC '", name, "' has garbled field 0 (",
zeroIds, "/", sampleSize, " records with ID=0) — falling back to binary DBC");
dbcData.clear();
std::string dbcPath = "DBFilesClient\\" + name;
dbcData = readFile(dbcPath);
if (!dbcData.empty()) {
dbc = std::make_shared<DBCFile>();
if (!dbc->load(dbcData)) {
LOG_ERROR("Binary DBC fallback also failed: ", name);
return nullptr;
}
LOG_INFO("Binary DBC fallback succeeded: ", name);
} else {
LOG_WARNING("No binary DBC fallback available for: ", name);
}
}
}
dbcCache[name] = dbc;