From fb8377f3cae3857e96a02c7624c9d6ce31b6469b Mon Sep 17 00:00:00 2001 From: Kelsi Date: Thu, 12 Mar 2026 09:00:31 -0700 Subject: [PATCH] fix: dismiss loot roll popup when any player wins, not only when we win SMSG_LOOT_ROLL_WON signals the roll contest is over for this slot; clear pendingLootRollActive_ unconditionally so the popup does not linger if a different group member wins while we have not yet voted. --- src/game/game_handler.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp index 054d4865..25400302 100644 --- a/src/game/game_handler.cpp +++ b/src/game/game_handler.cpp @@ -20094,10 +20094,8 @@ void GameHandler::handleLootRollWon(network::Packet& packet) { winnerName.c_str(), iName.c_str(), rollName, static_cast(rollNum)); addSystemChatMessage(buf); - // Clear pending roll if it was ours - if (pendingLootRollActive_ && winnerGuid == playerGuid) { - pendingLootRollActive_ = false; - } + // Dismiss roll popup — roll contest is over regardless of who won + pendingLootRollActive_ = false; LOG_INFO("SMSG_LOOT_ROLL_WON: winner=", winnerName, " item=", itemId, " roll=", rollName, "(", rollNum, ")"); }