phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-25 08:30:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat: implement SMSG_ACHIEVEMENT_DELETED, SMSG_CRITERIA_DELETED, SMSG_FORCED_DEATH_UPDATE

Browse source 
- SMSG_ACHIEVEMENT_DELETED: removes achievement from earnedAchievements_ and
  achievementDates_ so the achievements UI stays accurate after revocation
- SMSG_CRITERIA_DELETED: removes criteria from criteriaProgress_ tracking
- SMSG_FORCED_DEATH_UPDATE: sets playerDead_ when server force-kills the
  player (GM command, scripted events) instead of silently consuming
This commit is contained in:
Kelsi 2026-03-12 21:28:24 -07:00
parent 758ca76bd3
commit fb8c251a82
1 changed files with 26 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/game/game_handler.cpp
View file

@ -2307,10 +2307,16 @@ void GameHandler::handlePacket(network::Packet& packet) {
case Opcode::SMSG_DAMAGE_CALC_LOG:
case Opcode::SMSG_DYNAMIC_DROP_ROLL_RESULT:
case Opcode::SMSG_DESTRUCTIBLE_BUILDING_DAMAGE:
case Opcode::SMSG_FORCED_DEATH_UPDATE:
// Consume — handled by broader object update or not yet implemented
packet.setReadPos(packet.getSize());
break;
case Opcode::SMSG_FORCED_DEATH_UPDATE:
// Server forces player into dead state (GM command, scripted event, etc.)
playerDead_ = true;
if (ghostStateCallback_) ghostStateCallback_(false); // dead but not ghost yet
LOG_INFO("SMSG_FORCED_DEATH_UPDATE: player force-killed");
packet.setReadPos(packet.getSize());
break;
// ---- Zone defense messages ----
case Opcode::SMSG_DEFENSE_MESSAGE: {
@ -2392,11 +2398,27 @@ void GameHandler::handlePacket(network::Packet& packet) {
// Time bias — consume without processing
packet.setReadPos(packet.getSize());
break;
case Opcode::SMSG_ACHIEVEMENT_DELETED:
case Opcode::SMSG_CRITERIA_DELETED:
// Consume achievement/criteria removal notifications
case Opcode::SMSG_ACHIEVEMENT_DELETED: {
// uint32 achievementId — remove from local earned set
if (packet.getSize() - packet.getReadPos() >= 4) {
uint32_t achId = packet.readUInt32();
earnedAchievements_.erase(achId);
achievementDates_.erase(achId);
LOG_DEBUG("SMSG_ACHIEVEMENT_DELETED: id=", achId);
}
packet.setReadPos(packet.getSize());
break;
}
case Opcode::SMSG_CRITERIA_DELETED: {
// uint32 criteriaId — remove from local criteria progress
if (packet.getSize() - packet.getReadPos() >= 4) {
uint32_t critId = packet.readUInt32();
criteriaProgress_.erase(critId);
LOG_DEBUG("SMSG_CRITERIA_DELETED: id=", critId);
}
packet.setReadPos(packet.getSize());
break;
}
// ---- Combat clearing ----
case Opcode::SMSG_ATTACKSWING_DEADTARGET: