phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-03 08:03:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: strict aliasing violation in handleQueryNextMailTime

Browse source 
reinterpret_cast<float*> on raw packet bytes is undefined behavior per
the C++ strict aliasing rule — compilers can optimize assuming uint8_t
and float never alias. Replaced with packet.readFloat() which uses
memcpy internally. Also switched to hasRemaining() for consistency.
This commit is contained in:
Kelsi 2026-03-29 18:46:34 -07:00
parent 2ae14d5d38
commit fc2c6bab40
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/game/inventory_handler.cpp
View file

@ -1665,9 +1665,10 @@ void InventoryHandler::handleReceivedMail(network::Packet& packet) {
} }
void InventoryHandler::handleQueryNextMailTime(network::Packet& packet) { void InventoryHandler::handleQueryNextMailTime(network::Packet& packet) {
if (packet.getSize() - packet.getReadPos() < 8) return; if (!packet.hasRemaining(8)) return;
float nextTime = *reinterpret_cast<const float*>(&packet.getData()[packet.getReadPos()]); // readFloat() uses memcpy internally, avoiding the strict aliasing violation
packet.readUInt32(); // skip // that the previous reinterpret_cast<float*> on raw packet bytes had.
float nextTime = packet.readFloat();
uint32_t count = packet.readUInt32(); uint32_t count = packet.readUInt32();
hasNewMail_ = (nextTime >= 0.0f && count > 0); hasNewMail_ = (nextTime >= 0.0f && count > 0);
packet.setReadPos(packet.getSize()); packet.setReadPos(packet.getSize());