phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: correct SMSG_BATTLEFIELD_STATUS Classic 1.12 packet layout

Browse source 
Classic uses queueSlot(4)+bgTypeId(4)+unk(2)+instanceId(4)+isReg(1)+statusId(4);
TBC/WotLK prefixes arenaType(1)+unk(1) before bgTypeId. Reading TBC format on
Classic caused bgTypeId to be read from wrong offset, corrupting BG queue state.
This commit is contained in:
Kelsi 2026-03-11 04:22:18 -07:00
parent 8493729a10
commit fed03f970c
1 changed files with 29 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/game/game_handler.cpp
View file

@ -12242,20 +12242,40 @@ void GameHandler::handleMoveKnockBack(network::Packet& packet) {
// ============================================================ // ============================================================
void GameHandler::handleBattlefieldStatus(network::Packet& packet) { void GameHandler::handleBattlefieldStatus(network::Packet& packet) {
// SMSG_BATTLEFIELD_STATUS wire format differs by expansion:
//
// Classic 1.12 (vmangos/cmangos):
// queueSlot(4) bgTypeId(4) unk(2) instanceId(4) isRegistered(1) statusId(4) [status fields...]
// STATUS_NONE sends only: queueSlot(4) bgTypeId(4)
//
// TBC 2.4.3 / WotLK 3.3.5a:
// queueSlot(4) arenaType(1) unk(1) bgTypeId(4) unk2(2) instanceId(4) isRated(1) statusId(4) [status fields...]
// STATUS_NONE sends only: queueSlot(4) arenaType(1)
if (packet.getSize() - packet.getReadPos() < 4) return; if (packet.getSize() - packet.getReadPos() < 4) return;
uint32_t queueSlot = packet.readUInt32(); uint32_t queueSlot = packet.readUInt32();
// Minimal packet = just queueSlot + arenaType(1) when status is NONE const bool classicFormat = isClassicLikeExpansion();
if (packet.getSize() - packet.getReadPos() < 1) {
LOG_INFO("Battlefield status: queue slot ", queueSlot, " cleared"); uint8_t arenaType = 0;
return; if (!classicFormat) {
// TBC/WotLK: arenaType(1) + unk(1) before bgTypeId
// STATUS_NONE sends only queueSlot + arenaType
if (packet.getSize() - packet.getReadPos() < 1) {
LOG_INFO("Battlefield status: queue slot ", queueSlot, " cleared");
return;
}
arenaType = packet.readUInt8();
if (packet.getSize() - packet.getReadPos() < 1) return;
packet.readUInt8(); // unk
} else {
// Classic STATUS_NONE sends only queueSlot + bgTypeId (4 bytes)
if (packet.getSize() - packet.getReadPos() < 4) {
LOG_INFO("Battlefield status: queue slot ", queueSlot, " cleared");
return;
}
} }
uint8_t arenaType = packet.readUInt8();
if (packet.getSize() - packet.getReadPos() < 1) return;
// Unknown byte
packet.readUInt8();
if (packet.getSize() - packet.getReadPos() < 4) return; if (packet.getSize() - packet.getReadPos() < 4) return;
uint32_t bgTypeId = packet.readUInt32(); uint32_t bgTypeId = packet.readUInt32();