4 commits

Author	SHA1	Message	Date
Pavel Okhlopkov	97106bd6ae	fix(render): code quality cleanup ... Magic number elimination: - Create protocol_constants.hpp, warden_constants.hpp, render_constants.hpp, ui_constants.hpp - Replace ~55 magic numbers across game_handler, warden_handler, m2_renderer_render Reduce nesting depth: - Extract 5 parseEffect* methods from handleSpellLogExecute (max indent 52 → 16 cols) - Extract resolveSpellSchool/playSpellCastSound/playSpellImpactSound from 3× duplicate audio blocks in handleSpellGo - Flatten SMSG_INVENTORY_CHANGE_FAILURE with early-return guards - Extract drawScreenEdgeVignette() for 3 duplicate vignette blocks DRY extract patterns: - Replace 12 compound expansion checks with isPreWotlk() across movement_handler (9), chat_handler (1), social_handler (1) const to constexpr: - Promote 23+ static const arrays/scalars to static constexpr across 12 source files Error handling: - Convert PIN auth from exceptions to std::optional<PinProof> - Add [[nodiscard]] to 15+ initialize/parse methods - Wrap ~20 unchecked initialize() calls with LOG_WARNING/LOG_ERROR Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>	2026-04-06 22:43:13 +03:00
Kelsi	548828f2ee	refactor: extract color write mask, name frustum epsilon, add comments ... - vk_pipeline: extract kColorWriteAll constant from 4 duplicated RGBA bitmask expressions across blend mode functions, with why-comment - frustum: name kMinNormalLenSq epsilon (1e-8) with why-comment — prevents division by zero on degenerate planes - dbc_loader: add why-comment on DBC field width validation — all fields are fixed 4-byte uint32 per format spec - pin_auth: replace 0x30 hex literal with '0' char constant, add why-comment on ASCII encoding for server HMAC compatibility	2026-03-30 15:02:47 -07:00
Kelsi	fd0da4486d	Fix PIN grid remap bitmask (support digits 8/9)	2026-02-13 00:41:02 -08:00
Kelsi	62a49644a5	Support PIN-required auth servers	2026-02-13 00:22:01 -08:00