5 commits

Author	SHA1	Message	Date
Pavel Okhlopkov	97106bd6ae	fix(render): code quality cleanup ... Magic number elimination: - Create protocol_constants.hpp, warden_constants.hpp, render_constants.hpp, ui_constants.hpp - Replace ~55 magic numbers across game_handler, warden_handler, m2_renderer_render Reduce nesting depth: - Extract 5 parseEffect* methods from handleSpellLogExecute (max indent 52 → 16 cols) - Extract resolveSpellSchool/playSpellCastSound/playSpellImpactSound from 3× duplicate audio blocks in handleSpellGo - Flatten SMSG_INVENTORY_CHANGE_FAILURE with early-return guards - Extract drawScreenEdgeVignette() for 3 duplicate vignette blocks DRY extract patterns: - Replace 12 compound expansion checks with isPreWotlk() across movement_handler (9), chat_handler (1), social_handler (1) const to constexpr: - Promote 23+ static const arrays/scalars to static constexpr across 12 source files Error handling: - Convert PIN auth from exceptions to std::optional<PinProof> - Add [[nodiscard]] to 15+ initialize/parse methods - Wrap ~20 unchecked initialize() calls with LOG_WARNING/LOG_ERROR Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>	2026-04-06 22:43:13 +03:00
Kelsi	9d1616a11b	audio: stop precast sound on spell completion, failure, or interrupt ... Add AudioEngine::playSound2DStoppable() + stopSound() so callers can hold a handle and cancel playback early. SpellSoundManager::playPrecast() now stores the handle in activePrecastId_; stopPrecast() cuts the sound. playCast() calls stopPrecast() before playing the release sound, so the channeling audio never bleeds past cast time. SMSG_SPELL_FAILURE and SMSG_CAST_FAILED both call stopPrecast() so interrupted casts silence immediately.	2026-03-09 21:04:24 -07:00
Kelsi	c998c945bf	Implement MPQ-path sound loading in AudioEngine ... Add AssetManager hookup to AudioEngine so the path-based playSound2D/3D overloads can load files on demand rather than requiring preloading. - Add setAssetManager() to AudioEngine (called during world load alongside other audio manager initializations) - playSound2D(mpqPath) now calls assetManager->readFile() then delegates to the vector<uint8_t> overload (removes the "not yet implemented" warning) - playSound3D(mpqPath, position) same — delegates to the fully spatialized vector overload (was previously silently falling back to 2D)	2026-02-17 18:52:19 -08:00
Kelsi	5171f9cad4	Fix taxi state sync and transport authority; reduce runtime log overhead; restore first-person self-hide	2026-02-11 22:27:02 -08:00
Kelsi	bd3f1921d1	Replace process-spawning audio with miniaudio for non-blocking playback ... Eliminates severe stuttering from fork/exec + disk I/O by streaming audio directly from memory using miniaudio library.	2026-02-09 00:40:50 -08:00