mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-05-07 01:23:52 +00:00
1d1cbafa95
Locks in the recent Camera setter NaN/range guards and the getRight/getUp fallback when forward is parallel to world up: - setPosition rejects NaN/inf - setRotation rejects NaN - setFov rejects NaN/0/negative/>=180 - setAspectRatio rejects NaN/<=0 - getRight/getUp return finite at +/-89 pitch (clamped path) - getRight/getUp degrade safely at exactly +/-90 (crosses to zero) Brings ctest target count to 30.
93 lines
3 KiB
C++
93 lines
3 KiB
C++
// Tests for rendering::Camera setter guards and degenerate-pose math.
|
|
#include <catch_amalgamated.hpp>
|
|
#include "rendering/camera.hpp"
|
|
#include <cmath>
|
|
#include <limits>
|
|
|
|
using namespace wowee::rendering;
|
|
|
|
TEST_CASE("Camera::setPosition rejects NaN/inf", "[camera]") {
|
|
Camera cam;
|
|
glm::vec3 originalPos = cam.getPosition();
|
|
|
|
cam.setPosition(glm::vec3(std::numeric_limits<float>::quiet_NaN(), 0, 0));
|
|
REQUIRE(cam.getPosition() == originalPos);
|
|
|
|
cam.setPosition(glm::vec3(std::numeric_limits<float>::infinity(), 0, 0));
|
|
REQUIRE(cam.getPosition() == originalPos);
|
|
|
|
cam.setPosition(glm::vec3(10, 20, 30));
|
|
REQUIRE(cam.getPosition() == glm::vec3(10, 20, 30));
|
|
}
|
|
|
|
TEST_CASE("Camera::setRotation rejects NaN", "[camera]") {
|
|
Camera cam;
|
|
cam.setRotation(45.0f, 30.0f);
|
|
cam.setRotation(std::numeric_limits<float>::quiet_NaN(), 60.0f);
|
|
// Yaw stays at 45, pitch stays at 30 (set was rejected wholesale)
|
|
glm::vec3 fwdAfterBad = cam.getForward();
|
|
cam.setRotation(45.0f, 30.0f);
|
|
REQUIRE(cam.getForward() == fwdAfterBad);
|
|
}
|
|
|
|
TEST_CASE("Camera::setFov rejects NaN/zero/180+", "[camera]") {
|
|
Camera cam;
|
|
float originalFov = cam.getFovDegrees();
|
|
|
|
cam.setFov(std::numeric_limits<float>::quiet_NaN());
|
|
REQUIRE(cam.getFovDegrees() == originalFov);
|
|
|
|
cam.setFov(0.0f);
|
|
REQUIRE(cam.getFovDegrees() == originalFov);
|
|
|
|
cam.setFov(-30.0f);
|
|
REQUIRE(cam.getFovDegrees() == originalFov);
|
|
|
|
cam.setFov(180.0f);
|
|
REQUIRE(cam.getFovDegrees() == originalFov);
|
|
|
|
cam.setFov(90.0f);
|
|
REQUIRE(cam.getFovDegrees() == 90.0f);
|
|
}
|
|
|
|
TEST_CASE("Camera::setAspectRatio rejects non-positive", "[camera]") {
|
|
Camera cam;
|
|
float originalAspect = cam.getAspectRatio();
|
|
cam.setAspectRatio(0.0f);
|
|
REQUIRE(cam.getAspectRatio() == originalAspect);
|
|
cam.setAspectRatio(-1.0f);
|
|
REQUIRE(cam.getAspectRatio() == originalAspect);
|
|
cam.setAspectRatio(std::numeric_limits<float>::quiet_NaN());
|
|
REQUIRE(cam.getAspectRatio() == originalAspect);
|
|
cam.setAspectRatio(2.0f);
|
|
REQUIRE(cam.getAspectRatio() == 2.0f);
|
|
}
|
|
|
|
TEST_CASE("Camera::getRight/getUp return finite at +/-89 pitch", "[camera]") {
|
|
Camera cam;
|
|
cam.setRotation(0.0f, 89.0f);
|
|
glm::vec3 r = cam.getRight();
|
|
glm::vec3 u = cam.getUp();
|
|
REQUIRE(std::isfinite(r.x));
|
|
REQUIRE(std::isfinite(r.y));
|
|
REQUIRE(std::isfinite(r.z));
|
|
REQUIRE(std::isfinite(u.x));
|
|
REQUIRE(std::isfinite(u.y));
|
|
REQUIRE(std::isfinite(u.z));
|
|
}
|
|
|
|
TEST_CASE("Camera::getRight/getUp degrade safely at +/-90 pitch", "[camera]") {
|
|
Camera cam;
|
|
// Force the degenerate pose: forward exactly = world up
|
|
cam.setRotation(0.0f, 90.0f);
|
|
glm::vec3 r = cam.getRight();
|
|
glm::vec3 u = cam.getUp();
|
|
REQUIRE(std::isfinite(r.x));
|
|
REQUIRE(std::isfinite(r.y));
|
|
REQUIRE(std::isfinite(r.z));
|
|
REQUIRE(std::isfinite(u.x));
|
|
REQUIRE(std::isfinite(u.y));
|
|
REQUIRE(std::isfinite(u.z));
|
|
// Right should be the +X fallback (since cross would be zero).
|
|
REQUIRE(r == glm::vec3(1.0f, 0.0f, 0.0f));
|
|
}
|