mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-04-08 14:13:52 +00:00
6dcc06697b
Extract ~1,700 lines / 60+ inline [this]-capturing lambdas from the monolithic
Application::setupUICallbacks() into 7 focused callback handler classes following
the ToastManager/ChatPanel::setupCallbacks() pattern already in the codebase.
New handlers (include/core/ + src/core/):
- NPCInteractionCallbackHandler NPC greeting/farewell/vendor/aggro voice
- AudioCallbackHandler Music, positional sound, level-up, achievement, LFG
- EntitySpawnCallbackHandler Creature/player/GO spawn, despawn, move, state
- AnimationCallbackHandler Death, respawn, combat, emotes, charge, sprint, vehicle
- TransportCallbackHandler Mount, taxi, transport spawn/move
- WorldEntryCallbackHandler World entry, unstuck, hearthstone, bind point
- UIScreenCallbackHandler Auth, realm selection, char selection/creation/deletion
application.cpp: 4,462 → 2,791 lines (−1,671)
setupUICallbacks: ~1,700 → ~50 lines (thin orchestrator)
Deduplication:
resolveSoundEntryPath() — was 3× copy-paste of SoundEntries.dbc lookup
resolveNpcVoiceType() — was 4× copy-paste of display-ID→voice detection
precacheNearbyTiles() — was 3× copy-paste of 17×17 tile loop
4 helper lambdas — promoted to private methods on WorldEntryCallbackHandler
State migration out of Application:
charge* (6 vars) → AnimationCallbackHandler
hearth*/worldEntry*/taxi* → WorldEntryCallbackHandler
pendingCreatedCharacterName_ → UIScreenCallbackHandler
Bug fixes:
- Duplicate `namespace core {` in application.hpp caused wowee::std pollution
- AppState forward decl in ui_screen_callback_handler.hpp was at wrong scope
- world_loader.cpp accessed moved member vars directly via friend; now uses handler API
37 lines
1.1 KiB
C++
37 lines
1.1 KiB
C++
#pragma once
|
|
|
|
#include <cstdint>
|
|
#include <glm/glm.hpp>
|
|
#include "audio/npc_voice_manager.hpp"
|
|
|
|
namespace wowee {
|
|
|
|
namespace rendering { class Renderer; }
|
|
namespace game { class GameHandler; }
|
|
namespace audio { class AudioCoordinator; }
|
|
namespace core { class EntitySpawner; }
|
|
|
|
namespace core {
|
|
|
|
/// Handles NPC interaction callbacks: greeting, farewell, vendor, aggro voice lines.
|
|
class NPCInteractionCallbackHandler {
|
|
public:
|
|
NPCInteractionCallbackHandler(EntitySpawner& entitySpawner,
|
|
rendering::Renderer* renderer,
|
|
game::GameHandler& gameHandler,
|
|
audio::AudioCoordinator* audioCoordinator);
|
|
|
|
void setupCallbacks();
|
|
|
|
private:
|
|
/// Resolve NPC voice type from GUID (eliminates 4x copy-paste of display-ID lookup)
|
|
audio::VoiceType resolveNpcVoiceType(uint64_t guid) const;
|
|
|
|
EntitySpawner& entitySpawner_;
|
|
rendering::Renderer* renderer_;
|
|
game::GameHandler& gameHandler_;
|
|
audio::AudioCoordinator* audioCoordinator_;
|
|
};
|
|
|
|
} // namespace core
|
|
} // namespace wowee
|