mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-05-09 10:33:51 +00:00
ac17d04f8c
Continues the modularization. Moves the four audit handlers (--validate-zone-pack, --validate-project-packs, --info-zone-deps, --info-project-deps) into their own file using the same handle<Family>(int& i, int argc, char** argv, int& outRc) pattern. Side-cleanup: the two project-scope audits had identical subprocess-fanout structure (enumerate zones → run per-zone command → tally PASS/FAIL → print summary). Consolidated that into a shared runPerZoneAudit helper. Saves ~80 lines of duplicated dispatch code. main.cpp drops 28,070 → 27,736 lines (-334). Audit family is fully self-contained (~330 lines), behavior unchanged (verified all 4 commands against existing test zones).
352 lines
13 KiB
C++
352 lines
13 KiB
C++
#include "cli_audits.hpp"
|
|
|
|
#include "pipeline/wowee_model.hpp"
|
|
#include <nlohmann/json.hpp>
|
|
|
|
#include <algorithm>
|
|
#include <cstdint>
|
|
#include <cstdio>
|
|
#include <cstdlib>
|
|
#include <cstring>
|
|
#include <filesystem>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
namespace wowee {
|
|
namespace editor {
|
|
namespace cli {
|
|
|
|
namespace {
|
|
|
|
// Walk every direct subdirectory of <projectDir> that contains a
|
|
// zone.json. Used by both --validate-project-packs and
|
|
// --info-project-deps to enumerate zones.
|
|
std::vector<std::string> enumerateZones(const std::string& projectDir) {
|
|
std::vector<std::string> zones;
|
|
namespace fs = std::filesystem;
|
|
for (const auto& entry : fs::directory_iterator(projectDir)) {
|
|
if (!entry.is_directory()) continue;
|
|
if (!fs::exists(entry.path() / "zone.json")) continue;
|
|
zones.push_back(entry.path().string());
|
|
}
|
|
std::sort(zones.begin(), zones.end());
|
|
return zones;
|
|
}
|
|
|
|
// Run --<perZoneFlag> for each zone via subprocess and report
|
|
// per-zone PASS/FAIL plus a project rollup. Generic so both
|
|
// audits share it.
|
|
int runPerZoneAudit(const std::string& projectDir,
|
|
const std::string& cmdName,
|
|
const std::string& perZoneFlag,
|
|
const std::string& selfPath,
|
|
const std::string& failHint) {
|
|
namespace fs = std::filesystem;
|
|
if (!fs::exists(projectDir) || !fs::is_directory(projectDir)) {
|
|
std::fprintf(stderr,
|
|
"%s: %s is not a directory\n",
|
|
cmdName.c_str(), projectDir.c_str());
|
|
return 1;
|
|
}
|
|
auto zones = enumerateZones(projectDir);
|
|
if (zones.empty()) {
|
|
std::fprintf(stderr,
|
|
"%s: %s contains no zones\n",
|
|
cmdName.c_str(), projectDir.c_str());
|
|
return 1;
|
|
}
|
|
int passed = 0, failed = 0;
|
|
std::printf("%s: %s\n", cmdName.c_str(), projectDir.c_str());
|
|
std::printf(" zones: %zu\n\n", zones.size());
|
|
for (const auto& z : zones) {
|
|
std::string cmd = "\"" + selfPath + "\" " + perZoneFlag + " \"" +
|
|
z + "\" > /dev/null 2>&1";
|
|
int rc = std::system(cmd.c_str());
|
|
std::string name = fs::path(z).filename().string();
|
|
if (rc == 0) {
|
|
++passed;
|
|
std::printf(" PASS %s\n", name.c_str());
|
|
} else {
|
|
++failed;
|
|
std::printf(" FAIL %s\n", name.c_str());
|
|
}
|
|
}
|
|
std::printf("\n Total: %d passed, %d failed\n", passed, failed);
|
|
if (failed == 0) {
|
|
std::printf(" PROJECT PASS\n");
|
|
} else {
|
|
std::printf(" PROJECT FAIL%s%s\n",
|
|
failHint.empty() ? "" : " — ",
|
|
failHint.c_str());
|
|
}
|
|
return failed == 0 ? 0 : 1;
|
|
}
|
|
|
|
int handleZoneDeps(int& i, int argc, char** argv) {
|
|
// Broken-reference audit: walk every WOM in the zone, collect
|
|
// its texturePaths, and check whether each path resolves to a
|
|
// real file via 4 candidate locations (as-is, relative to
|
|
// zone, in textures/, alongside the WOM).
|
|
std::string zoneDir = argv[++i];
|
|
bool jsonOut = (i + 1 < argc &&
|
|
std::strcmp(argv[i + 1], "--json") == 0);
|
|
if (jsonOut) i++;
|
|
namespace fs = std::filesystem;
|
|
if (!fs::exists(zoneDir + "/zone.json")) {
|
|
std::fprintf(stderr,
|
|
"info-zone-deps: %s has no zone.json\n", zoneDir.c_str());
|
|
return 1;
|
|
}
|
|
struct DepRef {
|
|
std::string womPath;
|
|
std::string texPath;
|
|
bool exists;
|
|
};
|
|
std::vector<DepRef> refs;
|
|
std::error_code ec;
|
|
for (const auto& e : fs::recursive_directory_iterator(zoneDir, ec)) {
|
|
if (!e.is_regular_file()) continue;
|
|
if (e.path().extension() != ".wom") continue;
|
|
std::string womRel = fs::relative(e.path(), zoneDir).string();
|
|
std::string base = e.path().string();
|
|
base = base.substr(0, base.size() - 4);
|
|
auto wom = wowee::pipeline::WoweeModelLoader::load(base);
|
|
for (const auto& tp : wom.texturePaths) {
|
|
if (tp.empty()) continue;
|
|
bool found = false;
|
|
fs::path candidates[4] = {
|
|
fs::path(tp),
|
|
fs::path(zoneDir) / tp,
|
|
fs::path(zoneDir) / "textures" / fs::path(tp).filename(),
|
|
e.path().parent_path() / fs::path(tp).filename(),
|
|
};
|
|
for (const auto& c : candidates) {
|
|
if (fs::exists(c, ec) && fs::is_regular_file(c, ec)) {
|
|
found = true;
|
|
break;
|
|
}
|
|
}
|
|
refs.push_back({womRel, tp, found});
|
|
}
|
|
}
|
|
std::sort(refs.begin(), refs.end(),
|
|
[](const DepRef& a, const DepRef& b) {
|
|
if (a.exists != b.exists) return !a.exists;
|
|
if (a.womPath != b.womPath) return a.womPath < b.womPath;
|
|
return a.texPath < b.texPath;
|
|
});
|
|
int total = static_cast<int>(refs.size());
|
|
int missing = 0;
|
|
for (const auto& r : refs) if (!r.exists) ++missing;
|
|
if (jsonOut) {
|
|
nlohmann::json j;
|
|
j["zone"] = zoneDir;
|
|
j["totalRefs"] = total;
|
|
j["missingRefs"] = missing;
|
|
nlohmann::json arr = nlohmann::json::array();
|
|
for (const auto& r : refs) {
|
|
arr.push_back({
|
|
{"wom", r.womPath},
|
|
{"texture", r.texPath},
|
|
{"exists", r.exists},
|
|
});
|
|
}
|
|
j["refs"] = arr;
|
|
std::printf("%s\n", j.dump(2).c_str());
|
|
return missing == 0 ? 0 : 1;
|
|
}
|
|
std::printf("Zone deps: %s\n", zoneDir.c_str());
|
|
std::printf(" total refs : %d\n", total);
|
|
std::printf(" missing refs : %d\n", missing);
|
|
if (refs.empty()) {
|
|
std::printf(" *no texture references in any WOM*\n");
|
|
return 0;
|
|
}
|
|
std::printf("\n exists WOM texture\n");
|
|
for (const auto& r : refs) {
|
|
std::printf(" %-6s %-35s %s\n",
|
|
r.exists ? "yes" : "NO",
|
|
r.womPath.c_str(),
|
|
r.texPath.c_str());
|
|
}
|
|
std::printf("\n %s\n", missing == 0
|
|
? "PASS — all texture references resolve"
|
|
: "FAIL — missing references above");
|
|
return missing == 0 ? 0 : 1;
|
|
}
|
|
|
|
int handleValidateZonePack(int& i, int argc, char** argv) {
|
|
// Audit a zone's open-format asset pack. Reports counts and
|
|
// total bytes per category (textures/, meshes/, audio/) plus
|
|
// any malformed WOMs or invalid WAVs. Exit code 1 if any
|
|
// check fails — useful in CI to gate that gen-zone-starter-pack
|
|
// output is healthy.
|
|
std::string zoneDir = argv[++i];
|
|
bool jsonOut = (i + 1 < argc &&
|
|
std::strcmp(argv[i + 1], "--json") == 0);
|
|
if (jsonOut) i++;
|
|
namespace fs = std::filesystem;
|
|
if (!fs::exists(zoneDir + "/zone.json")) {
|
|
std::fprintf(stderr,
|
|
"validate-zone-pack: %s has no zone.json\n", zoneDir.c_str());
|
|
return 1;
|
|
}
|
|
struct CatStats {
|
|
int count = 0;
|
|
uint64_t bytes = 0;
|
|
int invalid = 0;
|
|
std::vector<std::string> invalidPaths;
|
|
};
|
|
CatStats tex, mesh, audio;
|
|
std::error_code ec;
|
|
// Textures: PNGs under textures/ (8-byte signature check)
|
|
fs::path texDir = fs::path(zoneDir) / "textures";
|
|
if (fs::exists(texDir)) {
|
|
for (const auto& e : fs::recursive_directory_iterator(texDir, ec)) {
|
|
if (!e.is_regular_file()) continue;
|
|
if (e.path().extension() != ".png") continue;
|
|
tex.count++;
|
|
tex.bytes += e.file_size();
|
|
FILE* f = std::fopen(e.path().c_str(), "rb");
|
|
if (f) {
|
|
unsigned char sig[8];
|
|
bool ok = (std::fread(sig, 1, 8, f) == 8 &&
|
|
sig[0] == 0x89 && sig[1] == 'P' &&
|
|
sig[2] == 'N' && sig[3] == 'G');
|
|
std::fclose(f);
|
|
if (!ok) {
|
|
tex.invalid++;
|
|
tex.invalidPaths.push_back(
|
|
fs::relative(e.path(), zoneDir).string());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
// Meshes: WOMs under meshes/ (load & sanity check)
|
|
fs::path meshDir = fs::path(zoneDir) / "meshes";
|
|
if (fs::exists(meshDir)) {
|
|
for (const auto& e : fs::recursive_directory_iterator(meshDir, ec)) {
|
|
if (!e.is_regular_file()) continue;
|
|
if (e.path().extension() != ".wom") continue;
|
|
mesh.count++;
|
|
mesh.bytes += e.file_size();
|
|
std::string base = e.path().string();
|
|
base = base.substr(0, base.size() - 4);
|
|
auto wom = wowee::pipeline::WoweeModelLoader::load(base);
|
|
if (wom.vertices.empty() || wom.indices.empty() ||
|
|
wom.batches.empty()) {
|
|
mesh.invalid++;
|
|
mesh.invalidPaths.push_back(
|
|
fs::relative(e.path(), zoneDir).string());
|
|
}
|
|
}
|
|
}
|
|
// Audio: WAVs under audio/ (RIFF header check)
|
|
fs::path audDir = fs::path(zoneDir) / "audio";
|
|
if (fs::exists(audDir)) {
|
|
for (const auto& e : fs::recursive_directory_iterator(audDir, ec)) {
|
|
if (!e.is_regular_file()) continue;
|
|
if (e.path().extension() != ".wav") continue;
|
|
audio.count++;
|
|
audio.bytes += e.file_size();
|
|
FILE* f = std::fopen(e.path().c_str(), "rb");
|
|
if (f) {
|
|
char hdr[12];
|
|
bool ok = (std::fread(hdr, 1, 12, f) == 12 &&
|
|
std::memcmp(hdr, "RIFF", 4) == 0 &&
|
|
std::memcmp(hdr + 8, "WAVE", 4) == 0);
|
|
std::fclose(f);
|
|
if (!ok) {
|
|
audio.invalid++;
|
|
audio.invalidPaths.push_back(
|
|
fs::relative(e.path(), zoneDir).string());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
int totalCount = tex.count + mesh.count + audio.count;
|
|
int totalInvalid = tex.invalid + mesh.invalid + audio.invalid;
|
|
uint64_t totalBytes = tex.bytes + mesh.bytes + audio.bytes;
|
|
bool pass = (totalInvalid == 0 && totalCount > 0);
|
|
if (jsonOut) {
|
|
auto catJ = [](const CatStats& c) {
|
|
return nlohmann::json{
|
|
{"count", c.count},
|
|
{"bytes", c.bytes},
|
|
{"invalid", c.invalid},
|
|
{"invalidPaths", c.invalidPaths},
|
|
};
|
|
};
|
|
nlohmann::json j;
|
|
j["zone"] = zoneDir;
|
|
j["pass"] = pass;
|
|
j["totalCount"] = totalCount;
|
|
j["totalBytes"] = totalBytes;
|
|
j["totalInvalid"] = totalInvalid;
|
|
j["textures"] = catJ(tex);
|
|
j["meshes"] = catJ(mesh);
|
|
j["audio"] = catJ(audio);
|
|
std::printf("%s\n", j.dump(2).c_str());
|
|
return pass ? 0 : 1;
|
|
}
|
|
std::printf("Zone pack audit: %s\n", zoneDir.c_str());
|
|
std::printf("\n category count bytes invalid\n");
|
|
std::printf(" textures %5d %7llu %7d\n",
|
|
tex.count,
|
|
static_cast<unsigned long long>(tex.bytes),
|
|
tex.invalid);
|
|
std::printf(" meshes %5d %7llu %7d\n",
|
|
mesh.count,
|
|
static_cast<unsigned long long>(mesh.bytes),
|
|
mesh.invalid);
|
|
std::printf(" audio %5d %7llu %7d\n",
|
|
audio.count,
|
|
static_cast<unsigned long long>(audio.bytes),
|
|
audio.invalid);
|
|
std::printf(" ----------------------------------\n");
|
|
std::printf(" TOTAL %5d %7llu %7d\n",
|
|
totalCount,
|
|
static_cast<unsigned long long>(totalBytes),
|
|
totalInvalid);
|
|
for (const auto* cat : { &tex, &mesh, &audio }) {
|
|
for (const auto& p : cat->invalidPaths) {
|
|
std::printf(" INVALID %s\n", p.c_str());
|
|
}
|
|
}
|
|
std::printf("\n %s\n", pass ? "PASS — pack is healthy"
|
|
: "FAIL — see invalid paths above");
|
|
return pass ? 0 : 1;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
bool handleAudits(int& i, int argc, char** argv, int& outRc) {
|
|
if (std::strcmp(argv[i], "--info-zone-deps") == 0 && i + 1 < argc) {
|
|
outRc = handleZoneDeps(i, argc, argv);
|
|
return true;
|
|
}
|
|
if (std::strcmp(argv[i], "--info-project-deps") == 0 && i + 1 < argc) {
|
|
std::string projectDir = argv[++i];
|
|
std::string self = (argc > 0) ? argv[0] : "wowee_editor";
|
|
outRc = runPerZoneAudit(projectDir, "Project deps",
|
|
"--info-zone-deps", self,
|
|
"re-run --info-zone-deps on FAILing zones for detail");
|
|
return true;
|
|
}
|
|
if (std::strcmp(argv[i], "--validate-zone-pack") == 0 && i + 1 < argc) {
|
|
outRc = handleValidateZonePack(i, argc, argv);
|
|
return true;
|
|
}
|
|
if (std::strcmp(argv[i], "--validate-project-packs") == 0 && i + 1 < argc) {
|
|
std::string projectDir = argv[++i];
|
|
std::string self = (argc > 0) ? argv[0] : "wowee_editor";
|
|
outRc = runPerZoneAudit(projectDir, "Project pack audit",
|
|
"--validate-zone-pack", self, "");
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
} // namespace cli
|
|
} // namespace editor
|
|
} // namespace wowee
|