Kelsidavis-WoWee/include/auth/auth_handler.hpp
Pavel Okhlopkov 97106bd6ae fix(render): code quality cleanup
Magic number elimination:
- Create protocol_constants.hpp, warden_constants.hpp,
  render_constants.hpp, ui_constants.hpp
- Replace ~55 magic numbers across game_handler, warden_handler,
  m2_renderer_render

Reduce nesting depth:
- Extract 5 parseEffect* methods from handleSpellLogExecute
  (max indent 52 → 16 cols)
- Extract resolveSpellSchool/playSpellCastSound/playSpellImpactSound
  from 3× duplicate audio blocks in handleSpellGo
- Flatten SMSG_INVENTORY_CHANGE_FAILURE with early-return guards
- Extract drawScreenEdgeVignette() for 3 duplicate vignette blocks

DRY extract patterns:
- Replace 12 compound expansion checks with isPreWotlk() across
  movement_handler (9), chat_handler (1), social_handler (1)

const to constexpr:
- Promote 23+ static const arrays/scalars to static constexpr across
  12 source files

Error handling:
- Convert PIN auth from exceptions to std::optional<PinProof>
- Add [[nodiscard]] to 15+ initialize/parse methods
- Wrap ~20 unchecked initialize() calls with LOG_WARNING/LOG_ERROR

Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
2026-04-06 22:43:13 +03:00

119 lines
3.7 KiB
C++

#pragma once
#include "auth/srp.hpp"
#include "auth/auth_packets.hpp"
#include <memory>
#include <string>
#include <functional>
#include <array>
namespace wowee {
namespace network { class TCPSocket; class Packet; }
namespace auth {
struct Realm;
// Authentication state
enum class AuthState {
DISCONNECTED,
CONNECTED,
CHALLENGE_SENT,
CHALLENGE_RECEIVED,
PIN_REQUIRED,
AUTHENTICATOR_REQUIRED,
PROOF_SENT,
AUTHENTICATED,
REALM_LIST_REQUESTED,
REALM_LIST_RECEIVED,
FAILED
};
// Authentication callbacks
using AuthSuccessCallback = std::function<void(const std::vector<uint8_t>& sessionKey)>;
using AuthFailureCallback = std::function<void(const std::string& reason)>;
using RealmListCallback = std::function<void(const std::vector<Realm>& realms)>;
class AuthHandler {
public:
AuthHandler();
~AuthHandler();
// Connection
[[nodiscard]] bool connect(const std::string& host, uint16_t port = 3724);
void disconnect();
bool isConnected() const;
// Authentication
void authenticate(const std::string& username, const std::string& password);
void authenticate(const std::string& username, const std::string& password, const std::string& pin);
void authenticateWithHash(const std::string& username, const std::vector<uint8_t>& authHash);
void authenticateWithHash(const std::string& username, const std::vector<uint8_t>& authHash, const std::string& pin);
// Optional: when the auth server requires a PIN (securityFlags & 0x01), call this to continue.
// PIN must be 4-10 digits.
void submitPin(const std::string& pin);
// Generic continuation for PIN / authenticator-required servers.
void submitSecurityCode(const std::string& code);
// Set client version info (call before authenticate)
void setClientInfo(const ClientInfo& info) { clientInfo = info; }
const ClientInfo& getClientInfo() const { return clientInfo; }
// Realm list
void requestRealmList();
const std::vector<Realm>& getRealms() const { return realms; }
// State
AuthState getState() const { return state; }
const std::vector<uint8_t>& getSessionKey() const { return sessionKey; }
const std::string& getUsername() const { return username; }
// Callbacks
void setOnSuccess(AuthSuccessCallback callback) { onSuccess = callback; }
void setOnFailure(AuthFailureCallback callback) { onFailure = callback; }
void setOnRealmList(RealmListCallback callback) { onRealmList = callback; }
// Update (call each frame)
void update(float deltaTime);
private:
void sendLogonChallenge();
void handleLogonChallengeResponse(network::Packet& packet);
void sendLogonProof();
void handleLogonProofResponse(network::Packet& packet);
void sendRealmListRequest();
void handleRealmListResponse(network::Packet& packet);
void handlePacket(network::Packet& packet);
void setState(AuthState newState);
void fail(const std::string& reason);
std::unique_ptr<network::TCPSocket> socket;
std::unique_ptr<SRP> srp;
AuthState state = AuthState::DISCONNECTED;
std::string username;
std::string password;
ClientInfo clientInfo;
std::vector<uint8_t> sessionKey;
std::vector<Realm> realms;
// Callbacks
AuthSuccessCallback onSuccess;
AuthFailureCallback onFailure;
RealmListCallback onRealmList;
// Receive buffer
std::vector<uint8_t> receiveBuffer;
// Challenge security extension (PIN)
uint8_t securityFlags_ = 0;
uint32_t pinGridSeed_ = 0;
std::array<uint8_t, 16> pinServerSalt_{}; // from LOGON_CHALLENGE response
std::array<uint8_t, 16> checksumSalt_{}; // from LOGON_CHALLENGE response (integrity salt)
std::string pendingSecurityCode_;
};
} // namespace auth
} // namespace wowee